Set project as nullable #3042
Set project as nullable #3042
Conversation
| @@ -257,7 +257,7 @@ public void OnShowContractCommand(string nameOrHash) | |||
| ConsoleHelper.Info("", " Compiler: ", $"{contract.Nef.Compiler}"); | |||
| ConsoleHelper.Info("", " SourceCode: ", $"{contract.Nef.Source}"); | |||
| ConsoleHelper.Info("", " Trusts: ", $"[{string.Join(", ", contract.Manifest.Trusts.Select(s => s.ToJson()?.GetString()))}]"); | |||
| if (contract.Manifest.Extra is null) | |||
| if (contract.Manifest.Extra is not null) | |||
There was a problem hiding this comment.
someone must of changed the code, i don't write code like that.
|
may you also set all project as nullable? |
|
got warnings for Unchanged files with check annotations Beta |
Yes, I think that we can set all of them, but we can wait with neo, or make a different PR |
| { | ||
| if (NoWallet()) return; |
There was a problem hiding this comment.
This was another bug, we can't cancel without a wallet
|
@Jim8y we can do Neo, and Neo.Gui in another PR |
| @@ -45,7 +44,7 @@ private void OnTransferCommand(UInt160 tokenHash, UInt160 to, decimal amount, UI | |||
| Transaction tx; | |||
| try | |||
| { | |||
| tx = CurrentWallet.MakeTransaction(snapshot, new[] | |||
| tx = CurrentWallet!.MakeTransaction(snapshot, new[] | |||
There was a problem hiding this comment.
With nullable enabled, NoWallet would be unnecessary.
There was a problem hiding this comment.
You shouldn't do ! unless 100% sure its not going to be null. Set tx to nullable like Transaction? tx;. then check for null. That's the point of nullable. If you don't want it to be nullable than check return for null, and you dont have to use !. Also another point of nullable is for you to be checking for null.
There was a problem hiding this comment.
Also the reason why you are getting the warning for nullable is because your not doing null checking. For example if (tx == null).
There was a problem hiding this comment.
With noWallet you can use !
There was a problem hiding this comment.
With nullable enabled,
NoWalletwould be unnecessary.
How?
|
https://learn.microsoft.com/en-us/dotnet/api/system.nullable?view=net-7.0 |
* master: (30 commits) Set project as nullable (neo-project#3042) Fix: fix equal (neo-project#3028) Added README to packages (neo-project#3026) Nuget MyGet Fix (neo-project#3031) Add: print out the stack (neo-project#3033) fixed myget (neo-project#3029) Fixed MyGet Workflow (neo-project#3027) Package icons - hotfix (neo-project#3022) Nuget Package Icon & Symbols (neo-project#3020) Fix warning (neo-project#3021) Neo-node Migration (neo-project#2990) Remove unnecessary default seedlist (neo-project#2980) Fix Neo VM target frameworks (neo-project#2989) Update Neo.VM location in README.md (neo-project#2988) Migrating Neo VM (neo-project#2970) 3.6.2 (neo-project#2962) fix ut (neo-project#2959) Validate serialization during Contract deploy and Update (neo-project#2948) code optimization (neo-project#2958) check null scriptcontainer (neo-project#2953) ...
* master: Fixed asp.net core project (neo-project#3067) Updated BLS12_381 (neo-project#3074) avoid nonsense exception messages. (neo-project#3063) Removed `MyGet` (neo-project#3071) Updated unit-test (neo-project#3073) add hash verification for OnImport (neo-project#3070) Make public ReadUserInput (neo-project#3068) Removed asp.net core (neo-project#3065) Enforce Line Endings in `.editorconfig` (neo-project#3060) Remove some warnings (neo-project#3057) Fixed workflow timeout-minutes (neo-project#3048) Fix: specify the error message (neo-project#3030) Removes `WebSocket`s from the network layer (neo-project#3039) set timeout for tests (neo-project#3046) Fix: Editconfig (neo-project#3023) Set project as nullable (neo-project#3042) Fix: fix equal (neo-project#3028) # Conflicts: # src/Neo.CLI/CLI/MainService.cs # src/Neo.CLI/Settings.cs # src/Neo/ProtocolSettings.cs
Note: Two bugs in cli was also fixed during the nullable checks