Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: print out the stack #3033

Merged
merged 6 commits into from
Dec 25, 2023
Merged

Add: print out the stack #3033

merged 6 commits into from
Dec 25, 2023

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Dec 18, 2023

This pr override the ToString() to the EvaluationStack.

WIth this pr, we can print the stack while debuging the vm.

src/Neo.VM/EvaluationStack.cs Outdated Show resolved Hide resolved
tests/Neo.VM.Tests/UtEvaluationStack.cs Outdated Show resolved Hide resolved
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use DebuggerDisplayAttribute

@Jim8y
Copy link
Contributor Author

Jim8y commented Dec 19, 2023

Screenshot 2023-12-19 at 8 25 28 AM

i am expecting something like this, can it be achieved with "DebuggerDisplayAttribute"?

@shargon
Copy link
Member

shargon commented Dec 19, 2023

DebuggerDisplayAttribute is only for show the information while the cursor is above during the debug

@Jim8y
Copy link
Contributor Author

Jim8y commented Dec 21, 2023

All set, please review

shargon
shargon previously approved these changes Dec 25, 2023
@shargon shargon merged commit c78ac5a into neo-project:master Dec 25, 2023
1 of 2 checks passed
Jim8y added a commit to Jim8y/neo that referenced this pull request Dec 31, 2023
* master: (30 commits)
  Set project as nullable (neo-project#3042)
  Fix: fix equal (neo-project#3028)
  Added README to packages (neo-project#3026)
  Nuget MyGet Fix (neo-project#3031)
  Add: print out the stack (neo-project#3033)
  fixed myget (neo-project#3029)
  Fixed MyGet Workflow (neo-project#3027)
  Package icons - hotfix (neo-project#3022)
  Nuget Package Icon & Symbols (neo-project#3020)
  Fix warning (neo-project#3021)
  Neo-node Migration (neo-project#2990)
  Remove unnecessary default seedlist (neo-project#2980)
  Fix Neo VM target frameworks (neo-project#2989)
  Update Neo.VM location in README.md (neo-project#2988)
  Migrating Neo VM (neo-project#2970)
  3.6.2 (neo-project#2962)
  fix ut (neo-project#2959)
  Validate serialization during Contract deploy and Update (neo-project#2948)
  code optimization (neo-project#2958)
  check null scriptcontainer (neo-project#2953)
  ...
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants