Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entries to Designation event #3397

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Add entries to Designation event #3397

merged 6 commits into from
Aug 8, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Jul 4, 2024

Description

Wait for more methods to create a new fork
Require #3362
Close #3389

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Pending

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon added blocked This issue can't be worked at the moment waiting-hardfork labels Jul 4, 2024
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be nice to have a unit-test.

src/Neo/SmartContract/Native/RoleManagement.cs Outdated Show resolved Hide resolved
@shargon
Copy link
Member Author

shargon commented Jul 5, 2024

The ut added also test that #3362 works fine :)

@shargon shargon marked this pull request as ready for review July 5, 2024 07:41
@shargon shargon changed the title Add entries to Designation event Add entries to Designation event Jul 5, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Jul 30, 2024

@shargon how about this pr? will need the hardfork somewhere else.

@vncoelho
Copy link
Member

I think this is worth proceeding.

@shargon
Copy link
Member Author

shargon commented Jul 30, 2024

@shargon how about this pr? will need the hardfork somewhere else.

Is waiting for more features in the same hardfork

@Jim8y
Copy link
Contributor

Jim8y commented Jul 31, 2024

@shargon how about this pr? will need the hardfork somewhere else.

Is waiting for more features in the same hardfork

I mean just create a pr that adds the hardfork, having a hardfork name will not cause any problem.

@Jim8y
Copy link
Contributor

Jim8y commented Jul 31, 2024

BTW, please resolve conflicts.

@shargon
Copy link
Member Author

shargon commented Jul 31, 2024

Also we can merge this, and not configure the HF, the feature will come with others when the HF is configured

@Jim8y Jim8y mentioned this pull request Aug 7, 2024
4 tasks
@Jim8y Jim8y changed the base branch from master to HF_Echidna August 7, 2024 16:28
@superboyiii
Copy link
Member

Test: PASS
Before HF_Echidna:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "txid": "0xd7039f3f8317b461097ca1ff393f3f39b5ea05276c790603b703b44e40784421",
        "executions": [
            {
                "trigger": "Application",
                "vmstate": "HALT",
                "exception": null,
                "gasconsumed": "2090550",
                "stack": [
                    {
                        "type": "Any"
                    }
                ],
                "notifications": [
                    {
                        "contract": "0x49cf4e5378ffcd4dec034fd98a174c5491e395e2",
                        "eventname": "Designation",
                        "state": {
                            "type": "Array",
                            "value": [
                                {
                                    "type": "Integer",
                                    "value": "4"
                                },
                                {
                                    "type": "Integer",
                                    "value": "42"
                                }
                            ]
                        }
                    }
                ]
            }
        ]
    }
}

After HF_Echidna:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "txid": "0x08a54e3183a2dd0f1e88303080b0b52d105a92c640c5504240d8863f1b14ea6b",
        "executions": [
            {
                "trigger": "Application",
                "vmstate": "HALT",
                "exception": null,
                "gasconsumed": "2090550",
                "stack": [
                    {
                        "type": "Any"
                    }
                ],
                "notifications": [
                    {
                        "contract": "0x49cf4e5378ffcd4dec034fd98a174c5491e395e2",
                        "eventname": "Designation",
                        "state": {
                            "type": "Array",
                            "value": [
                                {
                                    "type": "Integer",
                                    "value": "4"
                                },
                                {
                                    "type": "Integer",
                                    "value": "61"
                                },
                                {
                                    "type": "Array",
                                    "value": [
                                        {
                                            "type": "ByteString",
                                            "value": "AhJGxC9c3mJD/hg7FDYdohTlmdGyXPQoIA9kYK6qdBvh"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "AyHoH24FT3hSY3V9CZUzX1bSfJoXCfvds2sNNxVK6Boj"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "A111yY9zJv/n6nJrdzJbl7wG2NAIqzTZV1DJ22jYIMSP"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "A3briYQGk9je1GivNmTbNp0Av+2iHO7vFhX1Z66AzCMu"
                                        }
                                    ]
                                },
                                {
                                    "type": "Array",
                                    "value": [
                                        {
                                            "type": "ByteString",
                                            "value": "AxLpQlEVqhOWOqj0n3lsbSsjCHmuqD4XRYOHidQpCvwQ"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "AtbQ1aBGz24M4yvvNg+DNdAulA9//3VwKb2MTSyHgAGD"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "ArNnumlmTbihVD7I/jiNjx1Gl9SU/TZA+lRivjqm7Y9K"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "AlT/v0cbtmoZSJu6jfuPyMYo/lHralETJfkny2c5REB7"
                                        }
                                    ]
                                }
                            ]
                        }
                    }
                ]
            }
        ]
    }
}

@shargon
Copy link
Member Author

shargon commented Aug 8, 2024

Merged into HF_Echidna

@shargon shargon merged commit e63f10b into HF_Echidna Aug 8, 2024
3 of 4 checks passed
@shargon shargon deleted the designation-event branch August 8, 2024 08:54
Jim8y pushed a commit that referenced this pull request Oct 2, 2024
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue can't be worked at the moment hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Designated native RoleManagement events with old/new public keys
5 participants