-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entries to Designation
event
#3397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it would be nice to have a unit-test.
The ut added also test that #3362 works fine :) |
Designation
event
@shargon how about this pr? will need the hardfork somewhere else. |
I think this is worth proceeding. |
Is waiting for more features in the same hardfork |
I mean just create a pr that adds the hardfork, having a hardfork name will not cause any problem. |
BTW, please resolve conflicts. |
Also we can merge this, and not configure the HF, the feature will come with others when the HF is configured |
Test: PASS {
"jsonrpc": "2.0",
"id": 1,
"result": {
"txid": "0xd7039f3f8317b461097ca1ff393f3f39b5ea05276c790603b703b44e40784421",
"executions": [
{
"trigger": "Application",
"vmstate": "HALT",
"exception": null,
"gasconsumed": "2090550",
"stack": [
{
"type": "Any"
}
],
"notifications": [
{
"contract": "0x49cf4e5378ffcd4dec034fd98a174c5491e395e2",
"eventname": "Designation",
"state": {
"type": "Array",
"value": [
{
"type": "Integer",
"value": "4"
},
{
"type": "Integer",
"value": "42"
}
]
}
}
]
}
]
}
} After HF_Echidna: {
"jsonrpc": "2.0",
"id": 1,
"result": {
"txid": "0x08a54e3183a2dd0f1e88303080b0b52d105a92c640c5504240d8863f1b14ea6b",
"executions": [
{
"trigger": "Application",
"vmstate": "HALT",
"exception": null,
"gasconsumed": "2090550",
"stack": [
{
"type": "Any"
}
],
"notifications": [
{
"contract": "0x49cf4e5378ffcd4dec034fd98a174c5491e395e2",
"eventname": "Designation",
"state": {
"type": "Array",
"value": [
{
"type": "Integer",
"value": "4"
},
{
"type": "Integer",
"value": "61"
},
{
"type": "Array",
"value": [
{
"type": "ByteString",
"value": "AhJGxC9c3mJD/hg7FDYdohTlmdGyXPQoIA9kYK6qdBvh"
},
{
"type": "ByteString",
"value": "AyHoH24FT3hSY3V9CZUzX1bSfJoXCfvds2sNNxVK6Boj"
},
{
"type": "ByteString",
"value": "A111yY9zJv/n6nJrdzJbl7wG2NAIqzTZV1DJ22jYIMSP"
},
{
"type": "ByteString",
"value": "A3briYQGk9je1GivNmTbNp0Av+2iHO7vFhX1Z66AzCMu"
}
]
},
{
"type": "Array",
"value": [
{
"type": "ByteString",
"value": "AxLpQlEVqhOWOqj0n3lsbSsjCHmuqD4XRYOHidQpCvwQ"
},
{
"type": "ByteString",
"value": "AtbQ1aBGz24M4yvvNg+DNdAulA9//3VwKb2MTSyHgAGD"
},
{
"type": "ByteString",
"value": "ArNnumlmTbihVD7I/jiNjx1Gl9SU/TZA+lRivjqm7Y9K"
},
{
"type": "ByteString",
"value": "AlT/v0cbtmoZSJu6jfuPyMYo/lHralETJfkny2c5REB7"
}
]
}
]
}
}
]
}
]
}
} |
Merged into |
* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count
Description
Wait for more methods to create a new fork
Require #3362
Close #3389
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: