Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designation event extension #3549

Closed
roman-khimov opened this issue Aug 9, 2024 · 3 comments · Fixed by #3761
Closed

Designation event extension #3549

roman-khimov opened this issue Aug 9, 2024 · 3 comments · Fixed by #3761
Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U2 Seriously planned
Milestone
v0.108.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we don't have protocol parity with C# node. neo-project/neo#3397 has implemented an event extension.

Describe the solution you'd like

Port it to NeoGo.
@roman-khimov roman-khimov added I3 Minimal impact enhancement Improving existing functionality U2 Seriously planned S4 Routine labels Aug 9, 2024
@roman-khimov roman-khimov added this to the v0.107.0 milestone Aug 9, 2024
@AnnaShaleva
Copy link
Member

We can implement it, but just a note: this change was not merged into neo-project master.

@roman-khimov
Copy link
Member Author

I know, but it's a technical detail mostly now. Looks like we'll have some gigantic hf_echidna branch (like a dev branch) that will then be merged without any additional changes.

@AnnaShaleva
Copy link
Member

Depends on #3554.

@AnnaShaleva AnnaShaleva modified the milestones: v0.107.2, v0.108.0 Dec 13, 2024
AliceInHunterland added a commit that referenced this issue Dec 16, 2024
@AliceInHunterland
native: add Designation event extension after HFEchidna
a0a983c 
Close #3549

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland mentioned this issue Dec 16, 2024
Merged
AliceInHunterland added a commit that referenced this issue Dec 16, 2024
@AliceInHunterland
native: add Designation event extension after HFEchidna
34a698b 
Close #3549

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Dec 18, 2024
@AliceInHunterland
native: add Designation event extension after HFEchidna
416b1f7 
Close #3549

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Dec 23, 2024
@AliceInHunterland
native: add Designation event extension starting from HFEchidna
dd33eef 
Close #3549

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Dec 23, 2024
@AliceInHunterland
native: add Designation event extension starting from HFEchidna
d2da286 
Close #3549

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Dec 23, 2024
@AliceInHunterland
native: add Designation event extension starting from HFEchidna
79b0fcf 
Close #3549

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U2 Seriously planned
Projects
None yet
Milestone
v0.108.0
Development

Successfully merging a pull request may close this issue.

native: add Echidna changes nspcc-dev/neo-go
2 participants
@roman-khimov @AnnaShaleva