Plugin dll load method change. (2x) #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
approved these changes
Jun 11, 2019
vncoelho
reviewed
Jun 11, 2019
|
Versions of neo-plugins are latests neo-plugins are different, 2.10.2.0 and 2.10.2.1. Fell free to merge @shargon , we need another PR for extra adjustments, maybe neocli should optionally read both: plugin name and, optionally, version |
igormcoelho
approved these changes
Jun 11, 2019
| @@ -97,7 +97,8 @@ internal static void LoadPlugins(NeoSystem system) | |||
| if (!Directory.Exists(pluginsPath)) return; | |||
| foreach (string filename in Directory.EnumerateFiles(pluginsPath, "*.dll", SearchOption.TopDirectoryOnly)) | |||
| { | |||
| Assembly assembly = Assembly.LoadFile(filename); | |||
| var file = File.ReadAllBytes(filename); | |||
| Assembly assembly = Assembly.Load(file); | |||
There was a problem hiding this comment.
Very interesting solution... since sizes are very low, it shouldn't impact memory.
|
@Ashuaidehao, could you port this to master branch? |
Sure ,I have created another PR(#816) port to master branch. |
shargon
changed the title
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* [EN] Sync up with neo-project#809 [EN] Sync up with neo-project#809 * minor update * fix some
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently neo load plugin dll file directly, which will lock dll files and result in "uninstall" command fails.
So I change load method to load a copied dll file to resolve this issue.