Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin dll load method change. (2x) #810

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Plugin dll load method change. (2x) #810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
500a6cc
Plugin dll load method change.
Ashuaidehao Jun 11, 2019
278d646
Merge branch 'master-2.x' into feature/UnlockLoadPluginFile
Ashuaidehao Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion neo/Plugins/Plugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ internal static void LoadPlugins(NeoSystem system)
if (!Directory.Exists(pluginsPath)) return;
foreach (string filename in Directory.EnumerateFiles(pluginsPath, "*.dll", SearchOption.TopDirectoryOnly))
{
Assembly assembly = Assembly.LoadFile(filename);
var file = File.ReadAllBytes(filename);
Assembly assembly = Assembly.Load(file);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting solution... since sizes are very low, it shouldn't impact memory.

foreach (Type type in assembly.ExportedTypes)
{
if (!type.IsSubclassOf(typeof(Plugin))) continue;
Expand Down