-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP: Triggers for NeoContract #15
Conversation
Triggers.mediawiki
Outdated
|
||
==Abstract== | ||
|
||
Trigger is a mechanism for triggering execution for smart contracts. This NEP defines 4 kinds of triggers, they are <code>Verification</code>, <code>VerificationR</code>, <code>Application</code> and <code>ApplicationR</code>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since writing "two kinds of triggers " in Section "Rationale", you might wanna change "4 kinds of triggers" to "four different kinds of triggers"
Triggers.mediawiki
Outdated
|
||
==Rationale== | ||
|
||
Currently, we have two kinds of triggers in NeoContract: <code>Verification</code> and <code>Application</code>. These two triggers make smart contracts to be able to verify the transactions and modify the states of the blockchain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"These two triggers make smart contracts to be able to verify the transactions"
should maybe be changed to:
"These two triggers make smart contracts able to verify transactions"
Triggers.mediawiki
Outdated
|
||
===Verification=== | ||
|
||
This trigger indicates that the contract is being invoked as a verification function. The verification function can accept multiple parameters, and should return a boolean value that indicates the validity of the transaction or block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This trigger" could be made clearer by changing it into "The VerificationR
trigger indicates"
Triggers.mediawiki
Outdated
|
||
===VerificationR=== | ||
|
||
This trigger indicates that the contract is being invoked as a verification function because it is specified as a target of an output of the transaction. The verification function can accept no parameter, and should return a boolean value that indicates the validity of the transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "The verification function can accept no parameter" should be changed into "The verification function accepts no parameter" or "... function does not accept any parameter" or "... function takes no parameters"
Triggers.mediawiki
Outdated
|
||
===Application=== | ||
|
||
This trigger indicates that the contract is being invoked as an application function. The application function can accept multiple parameters, change the states of the blockchain, and return any type of value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The Application
trigger indicates that.."
Triggers.mediawiki
Outdated
|
||
===ApplicationR=== | ||
|
||
This trigger indicates that the contract is being invoked as an application function because it is specified as a target of an output of the transaction. The application function can accept no parameter, change the states of the blockchain, and return any type of value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The application function can accept no parameter" same as above: "takes no parameters" or any of the other suggestions :)
|
I supposed "reject"? |
@erikzhang wouldn't neo-project/neo#84 eliminate the need for this ? |
|
Is anyone assigned to this? Also I'm assuming the new triggers must only apply to |
They apply to every |
Trigger is a mechanism for triggering execution for smart contracts. This NEP defines 4 kinds of triggers, they are
Verification
,VerificationR
,Application
andApplicationR
.