NEP: URI Standard for Native Asset Transfer #25

saltyskip · 2018-01-15T04:51:37Z

No description provided.

to edit

snowypowers · 2018-01-15T07:05:29Z

nep-7.mediawiki

+
+===Native Asset Transfer URI===
+
+A Native asset transfer would have the following URI. It describes the reciever address, assetID, and additional attributes that will be sent with the transaction. The attributes are presented in raw hex data.


Native asset or Native Asset or native asset?

receiver spelling error

snowypowers · 2018-01-15T07:06:58Z

nep-7.mediawiki

+
+A Native asset transfer would have the following URI. It describes the reciever address, assetID, and additional attributes that will be sent with the transaction. The attributes are presented in raw hex data.
+
+<code>NEO:<address>[?assetID=<assetID>][?amount=<amount>][?attributes=<key>=<value>]</code>


I would prefer that the key/value pair be separated by another symbol. I think its good to follow querystring conventions, not sure if the decimal point in the amount will screw things up

I believe this follows query string convention. the decimal point will not screw things up. Please see sample implementation.

snowypowers · 2018-01-15T07:07:46Z

nep-7.mediawiki

+
+<code>NEO:AeNkbJdiMx49kBStQdDih7BzfDwyTNVRfb?assetID=c56f33fc6ecfcd0c225c4ab356fee59390af8560be0e930faebe74a6daff7c9b&amount=1.0</code>
+
+Begin transaction to specified address of 1 NEO with transaction attribute Remark = "Hello"


Can we have another example with 2 attributes? It is currently not clear if i can attach 2 or more attributes and how to do it.

One way we can do it is to just attach the entire attribute serialized string in. So a tx with 3 Hello remarks will be:

attributes=f00548656c6c6ff00548656c6c6ff00548656c6c6f

Whether we want to include the array length byte would be up to the standard.

Will do.
Here is the example of attaching more than one attributes. Implemented using standard URL package in Go.

https://play.golang.org/p/USCC87orRMS

snowypowers · 2018-01-15T07:12:19Z

nep-7.mediawiki

+| Script
+| Additional validation of transactions
+|-
+| 0x30


This would be pretty cool and useful to implement a vote for me button

erikzhang · 2018-01-15T07:29:34Z

nep-7.mediawiki

@@ -0,0 +1,117 @@
+<pre>
+ NEP: 7.0


The number 7 has been alloced for NEP: Triggers for NeoContract.
After a proposal being accepted, I will alloc a number for it.

erikzhang · 2018-01-17T08:42:59Z

As a URI standard for transfer, do we really need complete support for transaction attributes? Or do we just support some of the attributes associated with the transfer?
Like this:

neo:AQc5mtFayAdoCK13BW1cGAzAHyo9SoUWe7?asset=602c79718b16e442de58778e148d0b1084e3b2dffd5de6b7b16cee7969282de7&amount=0.1&description=Hello

apisit · 2018-01-17T09:22:27Z

Transaction attributes are optional.

I believe putting a list of supported attribute keys in the proposal can benefit developers who are reading it. It's just reflecting the NEO document right now.

An application might choose to support only one attribute key. e.g. 0x90 for description
A list of supported keys is there to help with validation when an application chooses to implement it.

I totally agree that the more human-readable URI, the better.

I was thinking about the case which an application can let user generate a QR code and pass one's public key for ECDH in 0x02 field.

e.g.
NEO:AQc5mtFayAdoCK13BW1cGAzAHyo9SoUWe7?assetID= 602c79718b16e442de58778e148d0b1084e3b2dffd5de6b7b16cee7969282de7&amount=0.1&attributes=0x02=02ed53ad58c838435d4dd7a4b25c1eba01384c814ca53a539405434807afbb04b4

what if we have a map table of transaction attribute and URI key?

e.g.

NEO transaction attribute	URI Key
0x02	publicKey
0x09	description
0xf0	remark1

note: not a complete list.

then it would be something like

NEO:AQc5mtFayAdoCK13BW1cGAzAHyo9SoUWe7?assetID= 602c79718b16e442de58778e148d0b1084e3b2dffd5de6b7b16cee7969282de7&amount=0.1&attributes=publicKey=02ed53ad58c838435d4dd7a4b25c1eba01384c814ca53a539405434807afbb04b4

erikzhang · 2018-01-17T09:52:30Z

If we have a map table of transaction attribute and URI key, can we use the keys in URI directly?
e.g.

neo:AQc5mtFayAdoCK13BW1cGAzAHyo9SoUWe7?assetID= 602c79718b16e442de58778e148d0b1084e3b2dffd5de6b7b16cee7969282de7&amount=0.1&publicKey=02ed53ad58c838435d4dd7a4b25c1eba01384c814ca53a539405434807afbb04b4&description=Hello

By the way, the scheme name of URI is usually lowercase.

Added URI key to NEO transaction attribute

saltyskip · 2018-02-18T09:07:43Z

A thorough reference implementation can be found here

https://github.com/O3Labs/NEP9-go

saltyskip · 2018-03-15T22:39:42Z

@erikzhang What Needs to be done to push this to Final?

erikzhang · 2018-03-16T07:05:13Z

I think we can support NEP-5 assets in this standard as well.

neo:<address>[?asset=<AssetID>|<ScriptHash>][&amount=<amount>][&<TransactionAttributeKey>=<value>]

If we want to transfer native asset, we put the AssetID to the asset field, which is 32-bytes length hash;

If we want to transfer NEP-5 asset, we put the ScriptHash of the contract to the asset field, which is 20-bytes length hash.

apisit · 2018-03-18T09:06:46Z

I have the implementation of NEP-5 asset transfer and smart contract invocation. I'll update the proposal tomorrow to get some feedback.

saltyskip · 2018-03-19T01:42:12Z

Won't this interfere with generic smart contract execution URI's in the future? If we do this then we'll have a specific format for a small subset of invoke transactions (NEP-5 token transfer) and another format for everything else?

Or is NEP-5 token transfer URI important enough such that it deserves it's own URI scheme?

erikzhang · 2018-03-20T07:22:48Z

If we have the generic smart contract execution URI's, we do not need a small subset of NEP-5 token transfer.

erikzhang · 2018-05-03T13:45:28Z

I wonder if the complete AssetID hash is really necessary... I mean, if it could be determined by the first initial hash values (such as 602c79), like github does for commit hashes, perhaps that would save some valuable space (maybe for qrcodes). The ambiguity can possibly become a problem here?

It is very easy to make two different hash values with same first few bytes.

igormcoelho · 2018-05-03T18:52:31Z

It is very easy to make two different hash values with same first few bytes.

But the asset must be registered in the main net, required to pay all fees... and if this happens, people could simply start using more bytes in uri. But I get your point, for security purposes it's safer to use the complete id.

In fact, that just gave me another idea, do you think it is useful to have some sort of checksum in the uri? That would help avoiding small fraudulent changes on uri, and it could consider the whole assetid in the count, even if only the first bytes are present... so a few extra space in the checksum (that would also check the whole uri) would be compensated by shorter assetid. Perhaps I'm overcomplicating things, but some thoughts may be useful :)

erikzhang · 2018-05-04T09:31:01Z

So what if the checksum itself be replaced?

- Removed `from` field in NEP5 Transfer URI - Added URI Keys for NEP5 Transfer - Added sample implementation

igormcoelho · 2018-05-08T04:26:28Z

So what if the checksum itself be replaced?

Then we will need a checksum of the checksum :D hahah just kidding. I mean Erik, the current URI has no checksum, so data can be manipulated anyway (but I agree that's not in the scope of the NEP). I'm just saying that perhaps those middle bytes of the assetid could be replaced by something that represents all transfer information (including the whole assetid), and an extra checksum, with fewer space. But theoretically speaking, I agree with you that there may exist another checksum that is coeherent with the manipulated assetid (not the original one, missing pieces), and also coherent with the rest of the data.. but I don't imagine how to generate it, really. In another way, perhaps it's just easier to allow "asset=NEO" or "asset=GAS", that will achieve the same effect with less complication than my proposal. The checksum can be optional anyway, as everything else I'm saying :D If anyone is interested I can create some practical examples to put here, but like I said, just a thought. ;)

mwherman2000 · 2018-05-15T15:17:02Z

Is this a valid query parameter string? i.e. multiple equal signs without the embedded equals sign being escaped?

attributes=0x02=02ed53ad58c838435d4dd7a4b25c1eba01384c814ca53a539405434807afbb04b4

...I can't find definitive reference for this but there it is a common convention for the query component of URI to be well-formed name=value pairs. e.g. https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Generic_syntax

apisit · 2018-05-17T01:16:57Z

@mwherman2000 You might saw the old one. It's already updated to use Transaction attribute name as a query key.

I have updated the proposal to include detail on endianness and optional fields for NEP5.

We have a simple implementation in JS of embedding a QR code generated with this NEP9 spec here

igormcoelho · 2018-05-17T17:35:35Z

This script for generating the QR Code is really nice, showing that my previous comments on compressing the URI (just for QR code usage) were actually not necessary :)
Congratulations for this nice NEP!

erikzhang · 2018-05-18T11:54:49Z

Can we handle the transfer of global assets and the transfer of NEP assets in a unified way?

neo:AeNkbJdiMx49kBStQdDih7BzfDwyTNVRfb?asset=602c79718b16e442de58778e148d0b1084e3b2dffd5de6b7b16cee7969282de7

For NEP-5 tokens:

neo:AeNkbJdiMx49kBStQdDih7BzfDwyTNVRfb?asset=ceab719b8baa2310f232ee0d277c061704541cfb

apisit · 2018-05-21T05:46:07Z

yeah that looks better.
I'll update it.

@erikzhang updated. Please have a look.

Unified native asset transfer and NEP-5 transfer

erikzhang · 2018-05-21T06:19:38Z

Two suggestions:

Now the article structure is a bit messy, can you rearrange it?
For the asset field, can we support the alias for neo and gas?

- Reorganized the page. - Allowing using `neo` and `gas` as an alias in native asset transfer.

erikzhang · 2018-05-22T09:55:21Z

Now we need to update the implementations.

apisit · 2018-05-23T03:15:06Z

I updated the implementations.

https://github.com/O3Labs/NEP9-go
https://github.com/O3Labs/nep9.js

erikzhang · 2018-05-23T05:37:48Z

One last question, should we mark it as Final or Active?

nickfujita · 2018-05-24T10:13:32Z

I've updated the sample QR code creation page to conform to the latest updates:

update assetID to asset
update for neo and gas aliases for asset
updates for nep5 token transfer compatability

This can be used as an example for QR code creation in accordance with NEP9.

https://o3.network/nep9/
source

apisit · 2018-06-04T00:16:23Z

@erikzhang I voted it to be Final

saltyskip · 2018-06-04T01:11:23Z

👍 for final

nickfujita · 2018-06-04T02:00:38Z

+1 to finalize! 💯

igormcoelho · 2018-06-07T15:22:20Z

Congratulations, that's nice! Seems final to me as well :) +1

apisit and others added 9 commits December 6, 2017 08:22

Create nep-7.mediawiki

4750708

to edit

Update nep-7.mediawiki

bc06d63

formatting

ef31f56

added NEP5 example & formatting

4e184fe

formatting

1364dbb

Update nep-7.mediawiki

d129ce4

Update nep-7.mediawiki

f788247

Update nep-7.mediawiki

0d1c031

Update nep-7.mediawiki

6ae2da5

snowypowers reviewed Jan 15, 2018

View reviewed changes

erikzhang reviewed Jan 15, 2018

View reviewed changes

Update and rename nep-7.mediawiki to URI-Scheme.mediawiki

a12b364

erikzhang changed the title ~~NEP-7 URI Standard for Native Asset Transfer~~ NEP: URI Standard for Native Asset Transfer Jan 15, 2018

erikzhang added the NEP-Standard label Jan 15, 2018

apisit added 2 commits January 15, 2018 16:55

Update URI-Scheme.mediawiki

4559158

Update URI-Scheme.mediawiki

fe869d3

Update URI-Scheme.mediawiki

9a1e887

Added URI key to NEO transaction attribute

erikzhang added the accepted label Jan 18, 2018

Update and rename URI-Scheme.mediawiki to nep-9.mediawiki

cf5e8f2

snowypowers mentioned this pull request Mar 16, 2018

[Feature] NEP9 Implementation CityOfZion/neon-js#195

Closed

added smart contract invocation, nep5 transfer

d279f7e

Update nep-9.mediawiki

6dd6df0

- Removed `from` field in NEP5 Transfer URI - Added URI Keys for NEP5 Transfer - Added sample implementation

Update nep-9.mediawiki

9246f21

Unified native asset transfer and NEP-5 transfer

apisit and others added 4 commits May 22, 2018 17:08

Update nep-9.mediawiki

0cd967a

- Reorganized the page. - Allowing using `neo` and `gas` as an alias in native asset transfer.

corrected asset field name

e4e5f1f

formatting

4fc33c9

Update nep-9.mediawiki

654709a

nickfujita mentioned this pull request Jun 5, 2018

[design-v2] Add NEP9 QR code creation to receive screen CityOfZion/neon-wallet#1186

Merged

shargon previously approved these changes Jun 8, 2018

View reviewed changes

erikzhang added 2 commits June 9, 2018 18:20

Merge remote-tracking branch 'origin/master' into master-O3Labs

9dc7585

change state to final

cf36c65

erikzhang dismissed shargon’s stale review via cf36c65 June 9, 2018 10:23

erikzhang merged commit 91aed6f into neo-project:master Jun 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NEP: URI Standard for Native Asset Transfer #25

NEP: URI Standard for Native Asset Transfer #25

saltyskip commented Jan 15, 2018

snowypowers Jan 15, 2018

snowypowers Jan 15, 2018

apisit Jan 15, 2018 •

edited

Loading

snowypowers Jan 15, 2018

apisit Jan 15, 2018

snowypowers Jan 15, 2018

erikzhang Jan 15, 2018

erikzhang commented Jan 17, 2018

apisit commented Jan 17, 2018

erikzhang commented Jan 17, 2018

saltyskip commented Feb 18, 2018

saltyskip commented Mar 15, 2018

erikzhang commented Mar 16, 2018

apisit commented Mar 18, 2018

saltyskip commented Mar 19, 2018

erikzhang commented Mar 20, 2018

erikzhang commented May 3, 2018 •

edited

Loading

igormcoelho commented May 3, 2018 •

edited

Loading

erikzhang commented May 4, 2018

igormcoelho commented May 8, 2018 •

edited

Loading

mwherman2000 commented May 15, 2018 •

edited

Loading

apisit commented May 17, 2018

igormcoelho commented May 17, 2018 •

edited

Loading

erikzhang commented May 18, 2018 •

edited

Loading

apisit commented May 21, 2018 •

edited

Loading

erikzhang commented May 21, 2018

erikzhang commented May 22, 2018

apisit commented May 23, 2018 •

edited

Loading

erikzhang commented May 23, 2018

nickfujita commented May 24, 2018

apisit commented Jun 4, 2018

saltyskip commented Jun 4, 2018

nickfujita commented Jun 4, 2018

igormcoelho commented Jun 7, 2018


		===Native Asset Transfer URI===

		A Native asset transfer would have the following URI. It describes the reciever address, assetID, and additional attributes that will be sent with the transaction. The attributes are presented in raw hex data.


		A Native asset transfer would have the following URI. It describes the reciever address, assetID, and additional attributes that will be sent with the transaction. The attributes are presented in raw hex data.

		<code>NEO:<address>[?assetID=<assetID>][?amount=<amount>][?attributes=<key>=<value>]</code>


		<code>NEO:AeNkbJdiMx49kBStQdDih7BzfDwyTNVRfb?assetID=c56f33fc6ecfcd0c225c4ab356fee59390af8560be0e930faebe74a6daff7c9b&amount=1.0</code>

		Begin transaction to specified address of 1 NEO with transaction attribute Remark = "Hello"

NEP: URI Standard for Native Asset Transfer #25

NEP: URI Standard for Native Asset Transfer #25

Conversation

saltyskip commented Jan 15, 2018

snowypowers Jan 15, 2018

Choose a reason for hiding this comment

snowypowers Jan 15, 2018

Choose a reason for hiding this comment

apisit Jan 15, 2018 • edited Loading

Choose a reason for hiding this comment

snowypowers Jan 15, 2018

Choose a reason for hiding this comment

apisit Jan 15, 2018

Choose a reason for hiding this comment

snowypowers Jan 15, 2018

Choose a reason for hiding this comment

erikzhang Jan 15, 2018

Choose a reason for hiding this comment

erikzhang commented Jan 17, 2018

apisit commented Jan 17, 2018

erikzhang commented Jan 17, 2018

saltyskip commented Feb 18, 2018

saltyskip commented Mar 15, 2018

erikzhang commented Mar 16, 2018

apisit commented Mar 18, 2018

saltyskip commented Mar 19, 2018

erikzhang commented Mar 20, 2018

erikzhang commented May 3, 2018 • edited Loading

igormcoelho commented May 3, 2018 • edited Loading

erikzhang commented May 4, 2018

igormcoelho commented May 8, 2018 • edited Loading

mwherman2000 commented May 15, 2018 • edited Loading

apisit commented May 17, 2018

igormcoelho commented May 17, 2018 • edited Loading

erikzhang commented May 18, 2018 • edited Loading

apisit commented May 21, 2018 • edited Loading

erikzhang commented May 21, 2018

erikzhang commented May 22, 2018

apisit commented May 23, 2018 • edited Loading

erikzhang commented May 23, 2018

nickfujita commented May 24, 2018

apisit commented Jun 4, 2018

saltyskip commented Jun 4, 2018

nickfujita commented Jun 4, 2018

igormcoelho commented Jun 7, 2018

apisit Jan 15, 2018 •

edited

Loading

erikzhang commented May 3, 2018 •

edited

Loading

igormcoelho commented May 3, 2018 •

edited

Loading

igormcoelho commented May 8, 2018 •

edited

Loading

mwherman2000 commented May 15, 2018 •

edited

Loading

igormcoelho commented May 17, 2018 •

edited

Loading

erikzhang commented May 18, 2018 •

edited

Loading

apisit commented May 21, 2018 •

edited

Loading

apisit commented May 23, 2018 •

edited

Loading