Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UTC DateTime Structures #374

Merged
merged 10 commits into from
Jul 21, 2022
Merged

Support UTC DateTime Structures #374

merged 10 commits into from
Jul 21, 2022

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Jun 16, 2022

✅ TestKit PR is: neo4j-drivers/testkit#470
✅ Extra TestKit PR: neo4j-drivers/testkit#495

@fbiville fbiville marked this pull request as ready for review June 17, 2022 15:40
@fbiville fbiville changed the title Hydrate UTC DateTime messages Support UTC DateTime Structures Jun 17, 2022
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me. However I've not spent so much time deep in thought on this, so perhaps worth getting one of the other driver authors to review as well.

neo4j/internal/bolt/hydrator.go Outdated Show resolved Hide resolved
@fbiville fbiville force-pushed the utc_fix branch 2 times, most recently from d5de5ac to 48265b8 Compare July 8, 2022 14:18
fbiville and others added 7 commits July 18, 2022 11:12
Signed-off-by: Florent Biville <florent.biville@neo4j.com>
Signed-off-by: Florent Biville <florent.biville@neo4j.com>
Co-authored-by: grant lodge <6323995+thelonelyvulpes@users.noreply.github.com>
 - fix type and value serialization
 - fix tz name serialization
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@fbiville
Copy link
Contributor Author

The only failing test here is flaky. Merging this.

@fbiville fbiville merged commit 1f9a872 into 5.0 Jul 21, 2022
@fbiville fbiville deleted the utc_fix branch July 21, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants