Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rollback optional when dealing with unknown time zones #495

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Conversation

fbiville
Copy link
Contributor

No description provided.

Signed-off-by: Florent Biville <florent.biville@neo4j.com>
Copy link
Contributor

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥅

@fbiville
Copy link
Contributor Author

JavaScript fails for unrelated reasons.
Java seems to fail because of the change (it counts 0 rollbacks). That's super weird, because it should have failed before this PR if no rollback occurs and the build passes on the 5.0 branch 🤔

@fbiville
Copy link
Contributor Author

Java is now fixed: neo4j/neo4j-java-driver#1269
Let's try again 🙏

@fbiville
Copy link
Contributor Author

Seems the Java failures are flaky and unrelated to this PR. Merging this now.

@fbiville fbiville merged commit 75da808 into 5.0 Jul 20, 2022
@fbiville fbiville deleted the go/utc branch July 20, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants