Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip more unknown timezone tests #1269

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Skip more unknown timezone tests #1269

merged 1 commit into from
Jul 19, 2022

Conversation

fbiville
Copy link
Contributor

These are currently passing by coincidence, as TestKit stub server
silently swallows the error, resulting from the Java driver early
connection close.

These are currently passing by coincidence, as TestKit stub server
silently swallows the error, resulting from the Java driver early
connection close.
@fbiville
Copy link
Contributor Author

The change on TestKit side to not swallow the error anymore is here: neo4j-drivers/testkit#496

Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎠

@fbiville
Copy link
Contributor Author

That empty PR triggers a superset of the current failures here, I'm merging this PR as a result.

@fbiville fbiville merged commit 6c3c1c7 into 5.0 Jul 19, 2022
@fbiville fbiville deleted the skip_extra_tk_tz_tests branch July 19, 2022 13:36
injectives pushed a commit to injectives/neo4j-java-driver that referenced this pull request Jul 20, 2022
These are currently passing by coincidence, as TestKit stub server
silently swallows the error, resulting from the Java driver early
connection close.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants