Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop shading dependencies in neo4j-java-driver package #1222

Merged
merged 1 commit into from
May 17, 2022

Conversation

injectives
Copy link
Contributor

@injectives injectives commented May 16, 2022

neo4j-java-driver package no longer includes shaded dependencies.

The new neo4j-java-driver-all package includes shaded Netty and Project Reactor dependencies.

@injectives injectives marked this pull request as draft May 16, 2022 14:44
`neo4j-java-driver` package no longer includes shaded dependencies.

The new `neo4j-java-driver-all` package includes shaded Netty and Project Reactor dependencies.
@injectives injectives changed the title Update packaging and introduce neo4j-java-driver-all package Stop shading dependencies in neo4j-java-driver package May 16, 2022
@injectives injectives marked this pull request as ready for review May 16, 2022 15:57
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I am surprised we don’t need to rearrange things more in poms to flip the switch. But than, cool that it works.

@injectives injectives merged commit 09e325a into neo4j:5.0 May 17, 2022
@injectives injectives deleted the feature/slim branch May 17, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants