Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

NML "tell" via loaded types #64

Closed
zkxs opened this issue Aug 19, 2022 · 2 comments · Fixed by #67
Closed

NML "tell" via loaded types #64

zkxs opened this issue Aug 19, 2022 · 2 comments · Fixed by #67
Assignees
@zkxs
Labels
security Security or privacy concerns

Comments

@zkxs
Copy link
Collaborator

zkxs commented Aug 19, 2022

LogiX can be used to make a user write a type such as NeosModLoader.NeosMod, NeosModSettings.NeosModSettings, etc into a TypeField and checking if it succeeded. This can be used to detect if users are running NML.
@zkxs zkxs added the security Security or privacy concerns label Aug 19, 2022
@zkxs zkxs mentioned this issue Aug 19, 2022
Merged
@zkxs
Copy link
Collaborator Author

zkxs commented Aug 19, 2022 •
edited
Loading

from @XDelta in #61:

I'd say our fix should be part of NML. Would be a better default than needing a mod

I agree. My intent was for a base NML install to be undetectable.

@EIA485
Copy link
Member

EIA485 commented Aug 20, 2022

just to cross pollinate my thoughts from #61
we should probably add the fix to the loader its self but have a config option to disable it.

@zkxs zkxs self-assigned this Aug 22, 2022
zkxs added a commit that referenced this issue Aug 22, 2022
@zkxs
Fix #64
31d9cc3
zkxs added a commit that referenced this issue Aug 22, 2022
@zkxs
Fix #64
69520a9
@zkxs zkxs mentioned this issue Aug 22, 2022
Merged
@zkxs zkxs closed this as completed in #67 Aug 29, 2022
zkxs added a commit that referenced this issue Aug 29, 2022
@zkxs
Hide modding-related types from TypeHelper.FindType (#67)
635592b 
* Fix #64

* Add a debug log

* Add a configuration to disable this feature

* Document why I remove NML and harmony
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zkxs zkxs

Labels
security Security or privacy concerns
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide modding-related types from TypeHelper.FindType neos-modding-group/NeosModLoader
2 participants
@zkxs @EIA485