Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Disclaimer about detectability #61

Merged
merged 3 commits into from
Aug 21, 2022
Merged

Disclaimer about detectability #61

merged 3 commits into from
Aug 21, 2022

Conversation

DoubleStyx
Copy link
Contributor

@DoubleStyx DoubleStyx commented Aug 19, 2022

Adding note regarding whether NML is detectable by other users

Warning about mod detection
@EIA485
Copy link
Member

EIA485 commented Aug 19, 2022

we were discussing fixing this issue on the nml side, guess it could also be done in a mod. imo it would be better to fix it in a mod but expose whats needed for the fix in nml

@DoubleStyx
Copy link
Contributor Author

Should I close the pr and open an issue for this instead?

@zkxs
Copy link
Collaborator

zkxs commented Aug 19, 2022

I think an issue to track this is good, so I've made one: #64. That doesn't mean we need to close this PR. In fact, I think you should just link to #64 instead of explaining the whole thing in the FAQ.

@XDelta
Copy link
Member

XDelta commented Aug 19, 2022

I'd say our fix should be part of NML. Would be a better default than needing a mod

@zkxs zkxs mentioned this pull request Aug 19, 2022
@EIA485
Copy link
Member

EIA485 commented Aug 19, 2022

now that i think about it, the only reason to not make it apart of nml is to do some weird stuff. i think a good compromise would be to add it to nml but with a config option to disable it.

@XDelta
Copy link
Member

XDelta commented Aug 19, 2022

I dunno if anything would potentially break at the moment with the required change so an option to disable could exist but hopefully shouldn't be needed

doc/faq.md Outdated
@@ -27,6 +27,8 @@ Yes, so long as Neos's [Mod & Plugin Policy] is followed.
## Will people know I'm using mods?

- By default, NeosModLoader does not do anything identifiable over the network. You will appear to be running the vanilla Neos version to any component that shows your version strings or compatibility hash.
- It is still technically possible for a user to determine if you are running NeosModLoader or a specific mod, although this requires a specific LogiX setup.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to #64 so that interested users can track the issue progress. Also, consider removing much (or all) of the explanation as interested users can read that in #64.

Copy link
Collaborator

@zkxs zkxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm mentally prepared to forget about this bullet point for weeks after we've fixed the issue.

@zkxs zkxs merged commit 2598543 into neos-modding-group:master Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants