-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Warning about mod detection
we were discussing fixing this issue on the nml side, guess it could also be done in a mod. imo it would be better to fix it in a mod but expose whats needed for the fix in nml |
Should I close the pr and open an issue for this instead? |
I'd say our fix should be part of NML. Would be a better default than needing a mod |
now that i think about it, the only reason to not make it apart of nml is to do some weird stuff. i think a good compromise would be to add it to nml but with a config option to disable it. |
I dunno if anything would potentially break at the moment with the required change so an option to disable could exist but hopefully shouldn't be needed |
doc/faq.md
Outdated
@@ -27,6 +27,8 @@ Yes, so long as Neos's [Mod & Plugin Policy] is followed. | |||
## Will people know I'm using mods? | |||
|
|||
- By default, NeosModLoader does not do anything identifiable over the network. You will appear to be running the vanilla Neos version to any component that shows your version strings or compatibility hash. | |||
- It is still technically possible for a user to determine if you are running NeosModLoader or a specific mod, although this requires a specific LogiX setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm mentally prepared to forget about this bullet point for weeks after we've fixed the issue.
Adding note regarding whether NML is detectable by other users