Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8 #2233

Closed
kdambekalns opened this issue Nov 10, 2020 · 6 comments
Closed

Support for PHP 8 #2233

kdambekalns opened this issue Nov 10, 2020 · 6 comments

Comments

@kdambekalns
Copy link
Member

@kdambekalns
Copy link
Member Author

doctrine/commons is raised to 2.13.1 in #1880 and supports PHP 8 as of that version.

@kdambekalns
Copy link
Member Author

doctrine/dbal is raised to 2.12 in #1880 and supports PHP 8 as of that version.

@kdambekalns
Copy link
Member Author

The Doctrine dependencies need to be raised in Neos, too, once #1880 is merged.

@albe
Copy link
Member

albe commented Feb 26, 2021

With #2287 existing code runs on PHP 8. However, to fully support PHP 8 we need to be able to deal with union types, constructor properties and annotations (at least for proper proxy building).

First step is maybe to add meta-info on union types to the reflection service.

Edit: See #2404

@albe
Copy link
Member

albe commented Aug 13, 2021

PHP8 Attributes are now supported as of #2468 but #2404 is still WIP

@bwaidelich
Copy link
Member

@albe the related PRs have been merged, can this one be closed?

@albe albe closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants