Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Test against PHP 8 #2015

Merged
merged 1 commit into from
Aug 17, 2020
Merged

TASK: Test against PHP 8 #2015

merged 1 commit into from
Aug 17, 2020

Conversation

kdambekalns
Copy link
Member

No description provided.

@kdambekalns kdambekalns self-assigned this May 25, 2020
albe
albe reviewed May 25, 2020
View reviewed changes
composer.json Show resolved Hide resolved
@albe
Copy link
Member

albe commented Aug 13, 2020 •
edited
Loading

Guess we need to do one of two things to get this run tests:

I'd go with no. 1 - wdyt @kdambekalns ?

@kdambekalns
Copy link
Member Author

Yeah, let's go with the merge… after 6.3 is branched. Then fix everything that needs fixing—and if viable we can backport compatibility as far as possible.

@kdambekalns kdambekalns merged commit 89ef448 into neos:master Aug 17, 2020
@kdambekalns kdambekalns deleted the task/test-php8 branch August 17, 2020 12:05
@kdambekalns
Copy link
Member Author

Haha! So, there is no version of Doctrine ORM that supports PHP 8 (yet).

@kdambekalns kdambekalns mentioned this pull request Nov 10, 2020
Closed
@kdambekalns
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albe albe albe left review comments

Assignees

@kdambekalns kdambekalns

Labels
!!! Next major T: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdambekalns @albe