BUGFIX: Support slashes in texts property #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
bugfix/supportSlashesInTextsAndStrings
branch
from
84e0c73 to
d7a3c8a
Compare
mficzel
changed the title
|
Looks good. What is your question? |
|
@jonnitto the ongoing discussion with @grebaldi is wether the string content in afx is a string or fusion-string. The escaping in jsx behaves mostly like afx already does. This also affects the related question what kind of comments should be supported in afx from. I agree with @grebaldi that we should be as intuitive for editors with jsx background. However i would be fine with adding behavior such devs would consider better as jsx. |
grebaldi
approved these changes
Nov 10, 2018
|
I will merge this soonish and release togehter with @path as 1.1.0. |
Previously only single quotes were escaped in afx text nodes. This change introduces a more generic escaping via addslashes that includes slashes, single- and double-quotes. That way the rendered result of afx will match the expectation better. resolves: neos#2
mficzel
force-pushed
the
bugfix/supportSlashesInTextsAndStrings
branch
from
d7a3c8a to
ef6d3d0
Compare
kdambekalns
pushed a commit
to kdambekalns/fusion-afx
that referenced
this pull request
Dec 3, 2020
…ndStrings BUGFIX: Support slashes in texts property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only single quotes were escaped in afx text and string nodes. This changes
introduces a more generic escaping via addslashes that includes slashes, single- and double-quotes.
That way the rendered result of afx should match the expectation better.
resolves: #2