Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Support backslashes in string attributes #19

Merged
merged 4 commits into from
Nov 26, 2019
Merged

BUGFIX: Support backslashes in string attributes #19

merged 4 commits into from
Nov 26, 2019

Conversation

ComiR
Copy link
Contributor

@ComiR ComiR commented Jan 25, 2019

Analogous to #13.

@mficzel mficzel requested review from grebaldi and mficzel January 25, 2019 12:39
mficzel
mficzel requested changes May 13, 2019
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests do not work, so this cannot be merged. Could not figure out fast wether this is a problem of the parser or the tests.

@ComiR
Copy link
Contributor Author

ComiR commented May 14, 2019

The attribute values already have to be escaped.
The class value of <h1 class="\\o/">foobar</h1> is \o/, the one of <h1 class="\o/">foobar</h1> is only o/ due to \ only escaping the o.

I expanded the second test string a little to show this behaviour.

@davidspiola
Copy link

Hi Folks, are you guys still working on the issue?

@mficzel mficzel merged commit fe56270 into neos:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mficzel mficzel mficzel approved these changes

@grebaldi grebaldi Awaiting requested review from grebaldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ComiR @davidspiola @mficzel