Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: 9.0 Implement ContentSubgraphInterface::findAncestorNodes and countAncestorNodes #4349

Merged
merged 5 commits into from
Jun 22, 2023
Merged

FEATURE: 9.0 Implement ContentSubgraphInterface::findAncestorNodes and countAncestorNodes #4349

merged 5 commits into from
Jun 22, 2023

Conversation

nezaniel
Copy link
Member

This adds the (afaik) last missing subgraph queries: findAncestorNodes and countAncestorNodes.

Can lateron be used to refactor lots of stuff, a few demo examples are included.

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the 9.0 branch

@github-actions github-actions bot added the 9.0 label Jun 20, 2023
@mhsdesign mhsdesign mentioned this pull request Jun 20, 2023
Closed
6 tasks
mhsdesign
mhsdesign reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some early comments. Thank you so much for this awaited feature!!

... we can now also optimize the flow query parents ;)

@mhsdesign mhsdesign mentioned this pull request Jun 20, 2023
Merged
3 tasks
@mhsdesign mhsdesign changed the title 9.0: Implement ContentSubgraphInterface::findAncestorNodes and countAncestorNodes FEATURE: 9.0 Implement ContentSubgraphInterface::findAncestorNodes and countAncestorNodes Jun 21, 2023
@nezaniel nezaniel requested a review from mhsdesign June 22, 2023 10:55
@mhsdesign mhsdesign mentioned this pull request Jun 22, 2023
Closed
@nezaniel @bwaidelich
Update Neos.ContentGraph.DoctrineDbalAdapter/src/Domain/Repository/Co…
aec56d2 
…ntentSubgraph.php

Co-authored-by: Bastian Waidelich <b.waidelich@wwwision.de>
bwaidelich
bwaidelich approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet ancestor of mine!

@nezaniel nezaniel merged commit 120d056 into 9.0 Jun 22, 2023
@nezaniel nezaniel deleted the findAncestors branch June 22, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@dlubitz dlubitz dlubitz approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

@mficzel mficzel Awaiting requested review from mficzel

@grebaldi grebaldi Awaiting requested review from grebaldi

Assignees
No one assigned
Labels
9.0 Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nezaniel @bwaidelich @grebaldi @dlubitz @mhsdesign