Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lua-language-server): check if root dir is home directory #2110

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix(lua-language-server): check if root dir is home directory #2110

merged 1 commit into from
Sep 6, 2022

Conversation

uga-rosa
Copy link
Contributor

@uga-rosa uga-rosa commented Sep 5, 2022 •
edited
Loading

There have been cases reported where the absence of this check causes the home directory to be set as the workspace, resulting in an error message.

LSP[sumneko_lua] Your workspace is set to '/home/uga'. Lua language server refused to load this directory. Please check your configuration.[learn more here](https://github.com/sumneko/lua-language-server/wiki/Why-scanning-home-folder)

@uga-rosa uga-rosa changed the title fix(lua-language-server): Check if root_dir is $HOME fix(lua-language-server): Check if root dir is $HOME Sep 5, 2022
@uga-rosa uga-rosa mentioned this pull request Sep 5, 2022
Closed
@uga-rosa uga-rosa changed the title fix(lua-language-server): Check if root dir is $HOME fix(lua-language-server): Check if root dir is home directory Sep 5, 2022
@glepnir
Copy link
Member

glepnir commented Sep 5, 2022

ci failed your commit msg Check shoude be check

@uga-rosa uga-rosa changed the title fix(lua-language-server): Check if root dir is home directory fix(lua-language-server): check if root dir is home directory Sep 5, 2022
@uga-rosa
Copy link
Contributor Author

uga-rosa commented Sep 6, 2022

it may fix, so please run ci

@glepnir glepnir merged commit 79d4cb9 into neovim:master Sep 6, 2022
mangkoran added a commit to mangkoran/nvim-lspconfig that referenced this pull request Dec 15, 2024
@mangkoran
fix(lua_ls): return longest root path
765e664 
This commit doesn't address the case when root path == vim.env.HOME as
the case lack return when it's true (neovim#2110)

Fix neovim#3508
@mangkoran mangkoran mentioned this pull request Dec 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosheavni mosheavni mosheavni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uga-rosa @glepnir @mosheavni