fix(lua_ls): return longest root path #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit doesn't address the case when root path == vim.env.HOME as the case lack return when it's true (neovim#2110) Fix neovim#3508
glepnir
approved these changes
Dec 15, 2024
pitkling
approved these changes
Dec 16, 2024
|
Hi @justinmk is there any other thing that need to be addressed for this PR? |
|
Hi @dundargoc @justinmk could we have this PR merged to fix #3508 ? I read the linked discussion regarding util.root_pattern deprecation, however it seems it's postponed for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit doesn't address the case when root path == vim.env.HOME as the case lack return when it's true (#2110)
Fix #3508