Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotests image version bump for go 1.22 #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gotests image version bump for go 1.22 #62

wants to merge 2 commits into from

Conversation

radoslawc
Copy link
Contributor

gotests image version bump for go 1.22

@nephio-prow nephio-prow bot requested review from henderiw and johnbelamaric April 24, 2024 16:12
@radoslawc
Copy link
Contributor Author

/hold
this needs nephio-project/test-infra#259 image

@radoslawc
Copy link
Contributor Author

/unhold

liamfallon
liamfallon reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jul 24, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liamfallon
Once this PR has been reviewed and has the lgtm label, please assign s3wong for approval by writing /assign @s3wong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamfallon liamfallon liamfallon left review comments

@henderiw henderiw Awaiting requested review from henderiw

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@liamfallon liamfallon

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radoslawc @liamfallon