Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating gotests binaries #259

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

radoslawc
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation

/kind failing-test

/kind feature
/kind flake

What this PR does / why we need it:
golangci-lint update to work with go 1.22 updated other components as well
This resolves failing tests in nephio-project/nephio#597 and nephio-project/nephio#722

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@liamfallon
Copy link
Member

/approve

1 similar comment
@radoslawc
Copy link
Collaborator Author

/approve

@nephio-prow nephio-prow bot added the approved label Apr 26, 2024
Copy link
Collaborator

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

nephio-prow bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon, radoslawc, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [radoslawc,vjayaramrh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit d900b40 into nephio-project:main Apr 26, 2024
3 checks passed
@radoslawc radoslawc deleted the linters_update branch April 26, 2024 17:12
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants