Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed legacy root level modules #1206

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Feb 9, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@Raalsky Raalsky force-pushed the rj/legacy-root-level-modules-removal branch from 0d885fa to da8c4f2 Compare February 9, 2023 14:30
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 71.49% // Head: 71.47% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3dfc0b6) compared to base (fbdca9d).
Patch coverage: 59.02% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           dev/1.0.0    #1206      +/-   ##
=============================================
- Coverage      71.49%   71.47%   -0.02%     
=============================================
  Files            288      278      -10     
  Lines          13624    13618       -6     
=============================================
- Hits            9740     9734       -6     
  Misses          3884     3884              
Flag Coverage Δ
unit-pull-request 71.47% <59.02%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/legacy/oauth.py 100.00% <ø> (ø)
src/neptune/legacy/patterns.py 0.00% <ø> (ø)
src/neptune/legacy/utils.py 0.00% <ø> (ø)
src/neptune/new/integrations/utils.py 0.00% <0.00%> (ø)
src/neptune/legacy/experiments.py 53.33% <53.33%> (ø)
src/neptune/common/exceptions.py 62.33% <61.90%> (-0.83%) ⬇️
src/neptune/common/git_info.py 81.81% <81.81%> (ø)
src/neptune/__init__.py 100.00% <100.00%> (ø)
src/neptune/common/envs.py 100.00% <100.00%> (ø)
src/neptune/common/experiments.py 100.00% <100.00%> (+46.87%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Raalsky Raalsky changed the base branch from master to dev/1.0.0 February 9, 2023 15:07
@Raalsky Raalsky force-pushed the rj/legacy-root-level-modules-removal branch from 6f13c5e to 336d9a6 Compare February 10, 2023 10:21
@Raalsky Raalsky merged commit 68f0d38 into dev/1.0.0 Feb 10, 2023
@Raalsky Raalsky deleted the rj/legacy-root-level-modules-removal branch February 10, 2023 10:52
Raalsky added a commit that referenced this pull request Feb 14, 2023
Raalsky added a commit that referenced this pull request Feb 14, 2023
neptune.new modules made a root modules (#1213)

Co-authored-by: Sabine <sabine.nyholm@neptune.ai>

deprecate  function

Merged

remove test cases using get_last_run

remove exception related to get_last_run

update CHANGELOG

remove NeptuneUninitializedException from test_imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants