Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neptune.new modules made a root modules #1213

Merged
merged 33 commits into from
Feb 13, 2023
Merged

neptune.new modules made a root modules #1213

merged 33 commits into from
Feb 13, 2023

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Feb 10, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 71.47% // Head: 71.36% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (a65a574) compared to base (68f0d38).
Patch coverage: 89.03% of modified lines in pull request are covered.

❗ Current head a65a574 differs from pull request most recent head 882f37c. Consider uploading reports for the commit 882f37c to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           dev/1.0.0    #1213      +/-   ##
=============================================
- Coverage      71.47%   71.36%   -0.12%     
=============================================
  Files            278      284       +6     
  Lines          13618    13656      +38     
=============================================
+ Hits            9734     9745      +11     
- Misses          3884     3911      +27     
Flag Coverage Δ
unit-pull-request 71.36% <89.03%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/attributes/__init__.py 100.00% <ø> (ø)
src/neptune/attributes/atoms/__init__.py 100.00% <ø> (ø)
src/neptune/attributes/constants.py 100.00% <ø> (ø)
src/neptune/attributes/series/__init__.py 100.00% <ø> (ø)
src/neptune/attributes/sets/__init__.py 100.00% <ø> (ø)
src/neptune/cli/__main__.py 0.00% <0.00%> (ø)
src/neptune/integrations/aws/__init__.py 0.00% <0.00%> (ø)
src/neptune/integrations/detectron2/__init__.py 0.00% <0.00%> (ø)
src/neptune/integrations/fastai/__init__.py 0.00% <0.00%> (ø)
src/neptune/integrations/kedro/__init__.py 0.00% <0.00%> (ø)
... and 195 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

if last_run is None:
raise NeptuneUninitializedException()
return last_run
warn_once(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@normandy7 That's for you 😉

Examples:
>>> import neptune

>>> # Crate a new tracked run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor spelling error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that looks good to me, so will approve at once

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed + this function will be probably removed (and probably by you :P)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
@Raalsky Raalsky merged commit 4c2682b into dev/1.0.0 Feb 13, 2023
@Raalsky Raalsky deleted the rj/neptune-new branch February 13, 2023 08:44
Raalsky added a commit that referenced this pull request Feb 14, 2023
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Raalsky added a commit that referenced this pull request Feb 14, 2023
neptune.new modules made a root modules (#1213)

Co-authored-by: Sabine <sabine.nyholm@neptune.ai>

deprecate  function

Merged

remove test cases using get_last_run

remove exception related to get_last_run

update CHANGELOG

remove NeptuneUninitializedException from test_imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants