-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neptune.new modules made a root modules #1213
Conversation
Codecov ReportBase: 71.47% // Head: 71.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev/1.0.0 #1213 +/- ##
=============================================
- Coverage 71.47% 71.36% -0.12%
=============================================
Files 278 284 +6
Lines 13618 13656 +38
=============================================
+ Hits 9734 9745 +11
- Misses 3884 3911 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
if last_run is None: | ||
raise NeptuneUninitializedException() | ||
return last_run | ||
warn_once( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@normandy7 That's for you 😉
src/neptune/__init__.py
Outdated
Examples: | ||
>>> import neptune | ||
|
||
>>> # Crate a new tracked run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor spelling error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that looks good to me, so will approve at once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed + this function will be probably removed (and probably by you :P)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XD
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
neptune.new modules made a root modules (#1213) Co-authored-by: Sabine <sabine.nyholm@neptune.ai> deprecate function Merged remove test cases using get_last_run remove exception related to get_last_run update CHANGELOG remove NeptuneUninitializedException from test_imports
Before submitting checklist