Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pc/ Fix AttributeError: 'Loss' object has no attr 'func' #29

Merged
merged 11 commits into from
Jul 15, 2022
Merged

Pc/ Fix AttributeError: 'Loss' object has no attr 'func' #29

merged 11 commits into from
Jul 15, 2022

Conversation

Blaizzy
Copy link
Contributor

@Blaizzy Blaizzy commented May 20, 2022

Closes #22

@Blaizzy Blaizzy changed the title Pc/attr error func Pc/ Fix AttributeError: 'Loss' object has no attr 'func' May 20, 2022
@Blaizzy
Copy link
Contributor Author

Blaizzy commented May 20, 2022

Please merge #28 first as this PR builds on changes I made there.

@Raalsky
Copy link
Contributor

Raalsky commented Jul 15, 2022

Please update a Changelog 😉

@Raalsky
Copy link
Contributor

Raalsky commented Jul 15, 2022

Please merge #28 first as this PR builds on changes I made there.
FYI: You can edit a Pull Request and set the target branch as pc/vocab-error-fix instead of master 😉

@Blaizzy Blaizzy merged commit 9acbea1 into master Jul 15, 2022
@Blaizzy Blaizzy deleted the pc/attr-error-func branch July 15, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalsky Raalsky Raalsky approved these changes

@kamil-kaczmarek kamil-kaczmarek kamil-kaczmarek approved these changes

@SiddhantSadangi SiddhantSadangi SiddhantSadangi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: NeptuneCallback fails for losses other than BaseLoss
4 participants
@Blaizzy @Raalsky @kamil-kaczmarek @SiddhantSadangi