Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pc/ Fix AttributeError: 'Loss' object has no attr 'func' #29

Merged
merged 11 commits into from
Jul 15, 2022
Merged

Pc/ Fix AttributeError: 'Loss' object has no attr 'func' #29

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8d0ffcf
remove criterion from config dict
Blaizzy May 20, 2022
74fe3fb
add conditional to optimizer_criterion and redo config
Blaizzy May 20, 2022
698d7aa
add self
Blaizzy May 20, 2022
c385b03
re-commit
Blaizzy May 20, 2022
fdc0020
Minor refactoring
SiddhantSadangi Jul 12, 2022
a3439e5
Merge branch 'master' of https://github.com/neptune-ai/neptune-fastai…
Blaizzy Jul 15, 2022
72c448e
update changelog
Blaizzy Jul 15, 2022
e4699a9
chage repr
Blaizzy Jul 15, 2022
2f09994
update changelog
Blaizzy Jul 15, 2022
351a37f
update changelog
Blaizzy Jul 15, 2022
d352580
text formatting
Blaizzy Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions neptune_fastai/impl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,11 +207,14 @@ def _total_model_parameters(self) -> int:

@property
def _trainable_model_parameters(self) -> int:
return sum([p.numel() for p in trainable_params(self.learn)])
return sum(p.numel() for p in trainable_params(self.learn))

@property
def _optimizer_criterion(self) -> str:
return repr(self.loss_func.func)
if hasattr(self.learn.loss_func, 'func'):
return repr(self.loss_func.func)
else:
return repr(self.loss_func)
Raalsky marked this conversation as resolved.
Show resolved Hide resolved

@property
def _optimizer_hyperparams(self) -> Optional[dict]:
Expand Down Expand Up @@ -242,14 +245,10 @@ def _target(self) -> str:
return 'training' if self.learn.training else 'validation'

def _log_model_configuration(self):
self.neptune_run[f'{self.base_namespace}/config'] = {
config = {
'device': self._device,
'batch_size': self._batch_size,
'model': {
'vocab': {
'details': self._vocab,
'total': len(self._vocab)
},
'params': {
'total': self._total_model_parameters,
'trainable_params': self._trainable_model_parameters,
Expand All @@ -263,12 +262,19 @@ def _log_model_configuration(self):
}
}

if hasattr(self.learn.dls, 'vocab'):
config['model']['vocab'] = {
'details': self._vocab,
'total': len(self._vocab)
}

self.neptune_run[f'{self.base_namespace}/config'] = config

def after_create(self):
if not hasattr(self, 'save_model'):
if self.upload_saved_models:
warnings.warn(
'NeptuneCallback: SaveModelCallback is necessary for uploading model checkpoints.'
)
if not hasattr(self, 'save_model') and self.upload_saved_models:
warnings.warn(
'NeptuneCallback: SaveModelCallback is necessary for uploading model checkpoints.'
)

def before_fit(self):
self._log_model_configuration()
Expand Down