Extend API #194
Closed
Extend API #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated documentation in README to align with Swift 3
Add support for Swift Package Manager
* Remove not used Color extension * Duplicate Models to compile also with Linux * Added allTests property to make the tests executable also on Linux * Updated .travis.yml to use also Linux * Renamed travis scripts * Use the correct Script folder name * Updated permissions for travis scripts * Use swift version 4.2 on Linux * Added LinuxMain.swift * Try to make swift find LinuxMain file * Update LinuxMain permissions * Reverse 21892d6 * Updated macos install script * install bundler on macos * Use SPM default test location to make it find LinuxMain.swift * Fixed defaultTestSuite compilation issue for macOS and tvOS * Set correct path to the Tests info.plist * Don't use Bundle(for:) on Linux * Not use the Bundle at all on Linux * Make tests compile * Remove all the other Bundle(for:) calls on Linux * Fix: Use resourceName * Find files also on Fixtures folder * Remove objc compatibility * Remove spaces from User.swift file
Having this causes the wrong URL to be composed for enterprise hosted environment
* Add Post Review endpoint * Add test case * fix build error * run `swiftformat`
Bumps [activesupport](https://github.com/rails/rails) from 6.1.7.2 to 6.1.7.3. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.3/activesupport/CHANGELOG.md) - [Commits](rails/rails@v6.1.7.2...v6.1.7.3) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add swiftformat plugin for Package builds * Add Swiftformat vscode plugin * Fix devcontainer customizations * Use latest version
* Add FixtureGenerator * Add list option to gists * Sort keys * Add sorted keys command * Add generate all fixtures command * Add Issue command * Add repository command * Add Followers * Add label commands * Add PullRequest command * Add release command * Add Review command * Add star command * Add status command * Add user command * Run swiftformat * Add some info in README * Remove platforms * Rename to OctokitCLI * Compile CLI * Use Working Directory * Fix compiling on Linux * Change abstract
* Adding create pull request support * Updates from review * Add async version * Adding tests * Support older swift versions * Formatting tweaks to satisfy linter.
* add init for User * add init for Plan * add init for Status * add init for Review * add init for Repository * add init for File * add init for Gist * add init for Issue * add init for Label * add init for Milestone * add init for PullRequest * add init for Reactions * add init for Release * format Plan * execute SwiftFormat
* add endpoint for `List pull requests files` * replace with enum * fix accessibility * add test
* Use package for linting instead of clone * Update swiftformat
* Add pagination to PullRequests * Adding perPage to PullRequests --------- Co-authored-by: Seth Faxon <sfaxon@adobe.com>
* Run CI on main * Remove more master things
Co-authored-by: Seth Faxon <sfaxon@adobe.com>
* Add search code * Fix query param key * Fix search query key * Fix linting
* dateDecodingStrategy added as described in #184 (comment) * dateDecodingStrategy added as described in Issue #184.
* Add milestone api * Add async methods * Use string instead of date * Update page properties * Update Milestone.swift * Format code using swiftformat * Use old if lets * Update Milestone.swift * Update MilestoneTests.swift * Update MilestoneTests.swift * Update state property docs * Update Milestone.swift
* `Review.submittedAt` may be nil when just only created * add `Delete a pending review for a pull request` endpoint * add `Submit a review for a pull request` endpoint * add tests * replace `load` with `post` * run swiftformat * bump RequestKit to 3.3.0 * Resolve `FIXME`s * fix RequestKit version in xcodeproj
* Add API implementation for repository contents * Add unit tests for Repository Contents
* Add support for async await on all notification endpoints * Updated documentation and added mark notification thread as read/done methods * removed id from Subject, as it does not have one * Formatting + added constructors * Added async tests * lint * lint * more linting
… async await (#192) * Update Configuration.swift Added handleOpenURL and Authorize support async await * Update Configuration.swift lint
* add some more fields to repo, and structure for organization * add API to read a user's starred repositories * add test for repo updates * test org decoding; remove some invalid properties * remove duplicate methods to fetch starred repos * add Organization to all necessary targets * use local fork of RequestKit * fix tests * fix spm tool version * put back RequestKit dep * fix spm tool version again * fix lint issues --------- Co-authored-by: Andrew McKnight <git@mcknight.rocks>
…egular comments as well as comments to specific commits / line numbers)
|
It looks like your CI isn't working as expected. This compiles and tests fine on Xcode 15.4 and Xcode 16.1. |
4np
force-pushed
the
scratch/extend-API
branch
from
799287f to
61e97e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR:
commit ID,pathandlinenumber (see doc)Commentstructure, scoped ontoPullRequestas it differs from the issue comment.Commentstructure ontoIssue