Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final typing fixes + add Pyright to CI #1944

Merged
merged 8 commits into from
May 18, 2023
Merged

Final typing fixes + add Pyright to CI #1944

merged 8 commits into from
May 18, 2023

Conversation

tancik
Copy link
Contributor

@tancik tancik commented May 18, 2023

No description provided.

@brentyi brentyi self-requested a review May 18, 2023 02:15
@brentyi
Copy link
Collaborator

brentyi commented May 18, 2023

I'll try to get the rest 🙂

@brentyi brentyi self-assigned this May 18, 2023
@brentyi brentyi requested a review from jkulhanek May 18, 2023 08:16
@brentyi brentyi changed the title Final typing fixes Final typing fixes + add Pyright to CI May 18, 2023
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from my end -- a skim from @jkulhanek could be helpful

@jkulhanek
Copy link
Contributor

Looks good to me. I have left some comments.

@brentyi brentyi merged commit 2b0831b into main May 18, 2023
@brentyi brentyi deleted the final_type_fixes branch May 18, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants