refactor: remove redundant alias #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
approved these changes
Nov 20, 2018
bors bot
added a commit
that referenced
this pull request
Sep 1, 2020
2244: refactor: re-export crossbeam-channel r=doitian,yangby-cryptape a=zhangsoledad
## Description
re-export crossbeam-channel from facade wrapper, unify version specify.
use tilde requirements specify for crossbeam-channel, prevent automate dependency updates.
crossbeam-channel 0.4.3 has UB, may lead to jemalloc deadlock.
```
frame #0: 0x00007fb34acd5620 libpthread.so.0`__lll_lock_wait + 48
frame #1: 0x00007fb34accddf3 libpthread.so.0`__pthread_mutex_lock + 227
frame #2: 0x000056423ada57fc ckb`_rjem_je_malloc_mutex_lock_slow at mutex.h:141:2
frame #3: 0x000056423ada57f4 ckb`_rjem_je_malloc_mutex_lock_slow at mutex.c:84
frame #4: 0x000056423ad6e1a8 ckb`_rjem_je_arena_tcache_fill_small at mutex.h:205:4
frame #5: 0x000056423ad6e1a0 ckb`_rjem_je_arena_tcache_fill_small at arena.c:1261
frame #6: 0x000056423adc1494 ckb`_rjem_je_tcache_alloc_small_hard at tcache.c:93:2
frame #7: 0x000056423ad68618 ckb`mallocx at tcache_inlines.h:60:9
frame #8: 0x000056423ad685e0 ckb`mallocx at jemalloc.c:1709
frame #9: 0x000056423ad685e0 ckb`mallocx at jemalloc.c:1905
frame #10: 0x000056423ad685e0 ckb`mallocx at jemalloc.c:2005
frame #11: 0x000056423ad68324 ckb`mallocx at jemalloc.c:2588
frame #12: 0x000056423b16a56c ckb`alloc::raw_vec::RawVec$LT$T$C$A$GT$::reserve::h10a313223974a7d1 + 188
frame #13: 0x000056423b1a25f9 ckb`crossbeam_channel::flavors::array::Channel$LT$T$GT$::with_capacity::had6f123b9bc217e1 + 121
```
crossbeam-rs/crossbeam#533
#2235
also crossbeam-channel is not optimize for oneshot case. replace it if it is convenient.
Co-authored-by: zhangsoledad <787953403@qq.com>
XuJiandong
pushed a commit
to XuJiandong/ckb
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.