Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi-thread executor to execute network futures #5

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

zhangsoledad
Copy link
Member

No description provided.

quake
quake previously approved these changes Nov 20, 2018
@doitian doitian force-pushed the jjy/fix-multithread-tokio-executor branch from 8c41755 to 00774cf Compare November 20, 2018 07:55
@doitian doitian merged commit 3620f9c into develop Nov 20, 2018
@doitian doitian deleted the jjy/fix-multithread-tokio-executor branch November 20, 2018 07:55
@doitian doitian mentioned this pull request Nov 20, 2018
bors bot added a commit that referenced this pull request Sep 1, 2020
2244: refactor: re-export crossbeam-channel r=doitian,yangby-cryptape a=zhangsoledad

## Description

re-export crossbeam-channel from facade wrapper, unify version specify.
use tilde requirements specify for crossbeam-channel, prevent automate dependency updates.

crossbeam-channel 0.4.3 has UB, may lead to jemalloc deadlock.

```
    frame #0: 0x00007fb34acd5620 libpthread.so.0`__lll_lock_wait + 48
    frame #1: 0x00007fb34accddf3 libpthread.so.0`__pthread_mutex_lock + 227
    frame #2: 0x000056423ada57fc ckb`_rjem_je_malloc_mutex_lock_slow at mutex.h:141:2
    frame #3: 0x000056423ada57f4 ckb`_rjem_je_malloc_mutex_lock_slow at mutex.c:84
    frame #4: 0x000056423ad6e1a8 ckb`_rjem_je_arena_tcache_fill_small at mutex.h:205:4
    frame #5: 0x000056423ad6e1a0 ckb`_rjem_je_arena_tcache_fill_small at arena.c:1261
    frame #6: 0x000056423adc1494 ckb`_rjem_je_tcache_alloc_small_hard at tcache.c:93:2
    frame #7: 0x000056423ad68618 ckb`mallocx at tcache_inlines.h:60:9
    frame #8: 0x000056423ad685e0 ckb`mallocx at jemalloc.c:1709
    frame #9: 0x000056423ad685e0 ckb`mallocx at jemalloc.c:1905
    frame #10: 0x000056423ad685e0 ckb`mallocx at jemalloc.c:2005
    frame #11: 0x000056423ad68324 ckb`mallocx at jemalloc.c:2588
    frame #12: 0x000056423b16a56c ckb`alloc::raw_vec::RawVec$LT$T$C$A$GT$::reserve::h10a313223974a7d1 + 188
    frame #13: 0x000056423b1a25f9 ckb`crossbeam_channel::flavors::array::Channel$LT$T$GT$::with_capacity::had6f123b9bc217e1 + 121
```
crossbeam-rs/crossbeam#533
#2235

also crossbeam-channel is not optimize for oneshot case. replace it if it is convenient.


Co-authored-by: zhangsoledad <787953403@qq.com>
chenyukang added a commit to chenyukang/ckb that referenced this pull request Jun 29, 2023
chenyukang added a commit to chenyukang/ckb that referenced this pull request Jun 29, 2023
chenyukang added a commit to chenyukang/ckb that referenced this pull request Jul 5, 2023
chenyukang added a commit to chenyukang/ckb that referenced this pull request Jul 13, 2023
chenyukang added a commit to chenyukang/ckb that referenced this pull request Jul 13, 2023
chenyukang added a commit to chenyukang/ckb that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants