RFC: CKB Light Client Protocol #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
force-pushed
the
pr/light-client
branch
2 times, most recently
from
120b884 to
9ac858a
Compare
This was referenced Oct 11, 2022
5 tasks
doitian
reviewed
Oct 17, 2022
yangby-cryptape
force-pushed
the
pr/light-client
branch
from
9ac858a to
65db2b2
Compare
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Oct 18, 2022
3631: feat: add light client support to ckb full node r=zhangsoledad a=quake ### What problem does this PR solve? add light client support to ckb full node ### What is changed and how it works? related rfcs: [RFC(0043): CKB softfork activation](nervosnetwork/rfcs#349) [RFC: CKB Light Client Protocol](nervosnetwork/rfcs#370) [RFC: Client Side Block Filter Protocol](nervosnetwork/rfcs#375) ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note Note: Add a note under the PR title in the release note. ``` Co-authored-by: Boyu Yang <yangby@cryptape.com> Co-authored-by: quake <quake.wang@gmail.com> Co-authored-by: Linfeng Qian <thewawar@gmail.com> Co-authored-by: Quake Wang <quake.wang@gmail.com>
|
Use RFC Number 44 |
doitian
reviewed
Oct 19, 2022
yangby-cryptape
force-pushed
the
pr/light-client
branch
2 times, most recently
from
fc781dc to
69c0df4
Compare
doitian
reviewed
Oct 21, 2022
doitian
reviewed
Oct 21, 2022
doitian
reviewed
Oct 21, 2022
doitian
reviewed
Oct 21, 2022
doitian
reviewed
Oct 21, 2022
yangby-cryptape
force-pushed
the
pr/light-client
branch
2 times, most recently
from
393669e to
1350d31
Compare
janx
requested changes
Oct 22, 2022
yangby-cryptape
force-pushed
the
pr/light-client
branch
from
1350d31 to
a9e034e
Compare
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Oct 24, 2022
3648: chore(light-client): update according to the RFC changes r=zhangsoledad a=yangby-cryptape
### What problem does this PR solve?
- chore(light-client): update according to the RFC changes
- chore(light-client): rename the "hash" filed in HeaderDigest to "children_hash"
Ref: nervosnetwork/rfcs#370 (comment)
- docs(light-client): remove outdated documentation and link to the related RFC
- chore(deps): bump ckb-merkle-mountain-range from 0.5.1 to 0.5.2
### Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code ci-runs-only: [ quick_checks,linters ]
Side effects： None
### Release note
```release-note
None: Exclude this PR from the release note.
```
Co-authored-by: Boyu Yang <yangby@cryptape.com>
doitian
previously approved these changes
Oct 26, 2022
EthanYuan
reviewed
Oct 26, 2022
yangby-cryptape
force-pushed
the
pr/light-client
branch
from
a9e034e to
3319cd0
Compare
|
The last force-push did the follows:
|
2 tasks
yangby-cryptape
force-pushed
the
pr/light-client
branch
2 times, most recently
from
b8eb36d to
960ee88
Compare
|
The last force-push applied some suggestions from offline. |
zhangsoledad
reviewed
Nov 1, 2022
XuJiandong
requested changes
Nov 1, 2022
yangby-cryptape
force-pushed
the
pr/light-client
branch
from
960ee88 to
4d0f1a0
Compare
zhangsoledad
reviewed
Nov 2, 2022
zhangsoledad
reviewed
Nov 2, 2022
yangby-cryptape
force-pushed
the
pr/light-client
branch
from
4d0f1a0 to
f762ea2
Compare
zhangsoledad
approved these changes
Nov 2, 2022
XuJiandong
approved these changes
Nov 2, 2022
janx
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Click HERE to Preview.
TODO