-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC(0045): Client Side Block Filter Protocol #375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2022
5 tasks
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Oct 18, 2022
3631: feat: add light client support to ckb full node r=zhangsoledad a=quake ### What problem does this PR solve? add light client support to ckb full node ### What is changed and how it works? related rfcs: [RFC(0043): CKB softfork activation](nervosnetwork/rfcs#349) [RFC: CKB Light Client Protocol](nervosnetwork/rfcs#370) [RFC: Client Side Block Filter Protocol](nervosnetwork/rfcs#375) ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note Note: Add a note under the PR title in the release note. ``` Co-authored-by: Boyu Yang <yangby@cryptape.com> Co-authored-by: quake <quake.wang@gmail.com> Co-authored-by: Linfeng Qian <thewawar@gmail.com> Co-authored-by: Quake Wang <quake.wang@gmail.com>
doitian
previously approved these changes
Oct 19, 2022
Use RFC Number 45 |
janx
requested changes
Oct 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a new row to the RFC table in README.
Co-authored-by: busyforking <5958+janx@users.noreply.github.com> Co-authored-by: zhangsoledad <787953403@qq.com>
quake
changed the title
RFC: Client Side Block Filter Protocol
RFC(0045): Client Side Block Filter Protocol
Oct 26, 2022
quake
commented
Oct 26, 2022
doitian
reviewed
Oct 26, 2022
quake
force-pushed
the
quake/client-side-filter
branch
from
October 26, 2022 02:37
9425762
to
b6eefcf
Compare
quake
force-pushed
the
quake/client-side-filter
branch
from
October 26, 2022 02:40
b6eefcf
to
5e0625a
Compare
doitian
previously approved these changes
Oct 26, 2022
janx
approved these changes
Oct 31, 2022
janx
requested changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a row to the RFC list on README.
Co-authored-by: zhangsoledad <787953403@qq.com>
yangby-cryptape
suggested changes
Nov 8, 2022
Co-authored-by: Boyu Yang <yangby@cryptape.com>
Co-authored-by: Boyu Yang <yangby@cryptape.com>
janx
approved these changes
Nov 8, 2022
zhangsoledad
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREVIEW LINK