-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove end
keyword from NESTML models
#866
Conversation
the generated PyNestMLLexer.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this heroic effort! I just have a few minor comments.
doc/tutorials/active_dendrite/nestml_active_dendrite_tutorial.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many, many thanks! This looks like a massive improvement! I have added some comments to the code and have one general question about the documentation: Does it really make sense to have all the .rst
files in the repository? Can't they just be generated on Read the Docs and locally when they are needed?
@jougs I have created an issue to separate building the models documentation #880. We will address it in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions and a question on formulations of the text. Otherwise, I think I'm fine.
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Generated docs: https://nestml-doc.readthedocs.io/en/latest/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fantastic work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work. I checked the concept and the documentation.
Fixes #586