-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove units from spiking input ports #882
Conversation
the generated PyNestMLLexer.py
Thanks for all the work! I think we should stick to the original intention of the pull request, which was to remove units from spiking input ports. It is not clear at first glance what it means to have a unit next to an input port definition, so there is a high potential for mistakes. We should make it clear in the documentation that the units are 1/s, and the type checking system will take care of any potential inconsistencies. Unfortunately this will mean a little bit of extra syntax in the ODEs and convolutions where the units have to now be manually "multiplied in". |
doc/models_library/index.rst
Outdated
@@ -1,386 +1,49 @@ | |||
Models library | |||
============== | |||
|
|||
Neuron models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file still needs to be hand-tuned, unfortunately. Could you leave it as-is for this PR? We will pick it up again in #920.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a lot of work! Just a few minor comments, mostly documentation-related.
@@ -72,6 +74,23 @@ It is equivalent if either both `inhibitory` and `excitatory` are given, or neit | |||
- ... should be negative. It is added to the buffer with non-negative magnitude :math:`-w`. | |||
|
|||
|
|||
The incoming spikes at the spiking input port are modelled as Dirac delta function. The unit of the Dirac delta function follows from its definition | |||
|
|||
.. math:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect the definition of the Dirac delta pulse here, given the previous sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
Fixes #727
This is based on #866 which should be merged first.