chore: laying the grounds for 11.0.0 #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The payload and signOptions parameters have incorrect type checking, therefore possibly breaking the jsonwebtoken source code passing invalid payload and sign options. Scenario: if "expiresIn" has been set in the nestjs module and uses payload as a string, it'll break the code, because jsonwebtoken does not allow the use of "expiresIn" option with a string payload. In order to solve the problem, it is necessary predict the developer's behavior using types. Also throw an error in case of incorrect use of the sign method of the JwtService class.
…om/Hender-hs/jwt into Hender-hs-fix/sign-params-types-and-behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information