Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: laying the grounds for 11.0.0 #1337

Merged
merged 6 commits into from
Jun 15, 2023
Merged

chore: laying the grounds for 11.0.0 #1337

merged 6 commits into from
Jun 15, 2023

Commits on Mar 24, 2023

  1. fix(sign): fix sign parameters type and usage

    The payload and signOptions parameters have incorrect type checking,
    therefore possibly breaking the jsonwebtoken source code
    passing invalid payload and sign options.
    Scenario: if "expiresIn" has been set in the nestjs module and uses payload
    as a string, it'll break the code, because jsonwebtoken does not allow the use
    of "expiresIn" option with a string payload.
    In order to solve the problem, it is necessary predict the developer's behavior using types.
    Also throw an error in case of incorrect use of the sign method of the JwtService class.
    hender-hs committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    bea5df3 View commit details
    Browse the repository at this point in the history
  2. test(sign): JwtService sign param tests

    hender-hs committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    42c286c View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Configuration menu
    Copy the full SHA
    3b4138f View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix/sign-params-types-and-behavior' of https://github.c…

    …om/Hender-hs/jwt into Hender-hs-fix/sign-params-types-and-behavior
    kamilmysliwiec committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    18caa1c View commit details
    Browse the repository at this point in the history
  3. chore: minor changes

    kamilmysliwiec committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    60c3d6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    408b1cf View commit details
    Browse the repository at this point in the history