Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: laying the grounds for 10.0.0 #11517

Merged
merged 92 commits into from
Jun 12, 2023
Merged

chore: laying the grounds for 10.0.0 #11517

merged 92 commits into from
Jun 12, 2023

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Apr 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: v10.0.0

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Node v12 will be no longer supported in v10.0.0 (>= v16 is required).

A few PRs that are spanning this release:

so there's gonna be several barely noticeable breaking changes (that won't affect the vast majority of users anyway).

Besides, there will be some changes to the tooling-related packages too (CLI, schematics), etc, we'll most likely drop support for older versions of TypeScript than v4.8 (since there're several AST-related breaking changes between x < v4.8 and also v4 and v5).

Creating this PR for better visibility & transparency.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

leonardovillela and others added 30 commits December 12, 2021 23:32
Co-authored-by: Antonio T. as Tony <Tony133@users.noreply.github.com>
The redis microservice now makes use of `psubscribe` and `pmessage`
when the `wildcards` option is enabled in the options of the microservice,
which makes it possible to use wildcards as specified by the Redis
documentation.

Closes #10344
The search method is going to be anexed with the @Search decorator and
going to be used to reference a SEARCH request
This decorator uses the SEARCH method to construct a decorator
for a handler to a Search http request
This update was really simple, because we dont need any kind of aliasing
due to fastify and express already supporting the search method for Application
when transforming booleans with non-valid boolean values
on `ValidationPipe`, it must not return a valid boolean
	 and file-validator.interface and max-file-size.validator
@coveralls
Copy link

coveralls commented Apr 17, 2023

Pull Request Test Coverage Report for Build 7956b6f3-024e-43f8-a40d-3862b14b8225

  • 79 of 99 (79.8%) changed or added relevant lines in 24 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 92.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/container.ts 6 7 85.71%
packages/core/middleware/routes-mapper.ts 0 1 0.0%
packages/core/scanner.ts 15 16 93.75%
packages/core/middleware/builder.ts 11 13 84.62%
packages/microservices/server/server-redis.ts 7 9 77.78%
packages/core/router/router-explorer.ts 0 5 0.0%
packages/core/router/route-path-factory.ts 2 10 20.0%
Files with Coverage Reduction New Missed Lines %
packages/core/router/router-explorer.ts 1 73.78%
packages/core/scanner.ts 1 86.58%
Totals Coverage Status
Change from base Build 0b1348f7-1c5c-4876-8dd2-9bb11f4e38b6: 0.2%
Covered Lines: 6315
Relevant Lines: 6806

💛 - Coveralls

@wodCZ
Copy link
Contributor

wodCZ commented Apr 18, 2023

Hello!

Based on a Discord discussion, I'm proposing a change in lib and target options of tsconfig.jsons compilerOptions of Nest packages to ES2021.

That's the recommended mapping targeting Node16+ based on the typescripts docs.

This change could be split to two steps:

  • Bumping the version in starter, so new users of Nest 10 can make use of the new features
  • Bumping the version in core packages, where I'm not certain what the effect would be. My guess is smaller dist shipped to users thanks to less polyfills required to emulate the library TS code, or the ability to use latest ES features if it works the other way around.

I'm not experienced with what the target should be for libraries or the effect it has on users, so I can only leave this proposal here for better Ninjas to maybe consider.

Also, here some references that helped me understand a bit more:

Thanks, and good luck with the release 🎉

@kamilmysliwiec
Copy link
Member Author

@wodCZ If you take a look at changes in this PR, you'll notice that all samples & tsconfigs of libs in this repo were already updated to use ES2021 by default:

image

When the core package is updated, other official packages in the ecosystem will follow (and use es2021 as well). I'll make sure to update starter projects & schematics too

@XDoubleU
Copy link

Is there any estimated release date for v10 ? Especially waiting for #10953

@rubiin
Copy link
Contributor

rubiin commented May 7, 2023

@kamilmysliwiec lets pin this issue to get more input/ideas and also better visibility of the issue

@micalevisk
Copy link
Member

@XDoubleU there's no ETA


I think it's a good time to update the main lock file as well

image

@kamilmysliwiec kamilmysliwiec marked this pull request as ready for review May 19, 2023 11:17
Copy link
Contributor

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thing the target should be ES2021 here too

Copy link
Contributor

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are many methods that are supported by both express and fastify but missing in the enum
https://expressjs.com/en/4x/api.html#routing-methods
https://www.fastify.io/docs/latest/Reference/Routes/#routes-options

@kamilmysliwiec kamilmysliwiec merged commit a41e6bc into master Jun 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the 10.0.0 branch June 12, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.