Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep) platform-fastify: bump path-to-regexp #13964

Closed

Conversation

rolandsusans
Copy link

@rolandsusans rolandsusans commented Sep 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Fix security vulnerabilities

What is the current behavior?

Issue Number: 13955

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@rolandsusans rolandsusans marked this pull request as ready for review September 11, 2024 13:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build f1640004-b621-4e2e-a448-963a300b35b0

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.213%

Totals Coverage Status
Change from base Build 0b2170fc-d850-443a-8e46-397cb7d6d6fd: 0.0%
Covered Lines: 6750
Relevant Lines: 7320

💛 - Coveralls

@mbackermann
Copy link

I guess we should use 3.3.0. which also fixed the issue, but has no breaking changes

@rolandsusans
Copy link
Author

according to snyk 3.3.0 https://security.snyk.io/package/npm/path-to-regexp/3.3.0 is vulnerable as well 🤷🏻‍♂️

@rolandsusans
Copy link
Author

GHSA-9wv6-86v2-598j seems that 3.3.0 does the trick, will update the PR

@erichuang-bh
Copy link

erichuang-bh commented Sep 11, 2024

FYI:
image

The 3.3.0 may have the same issue.
https://avd.aquasec.com/nvd/2024/cve-2024-45296/

@rolandsusans
Copy link
Author

@erichuang-bh github it was updated just few hours ago:
image

Could it be, that the tool you are using does not have latest vulnerability db?

@kamilmysliwiec
Copy link
Member

Already fixed here #13971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants