Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: ids.config should only be installed when --enable-ids is set during configure #5356

Closed
glitsj16 opened this issue Sep 3, 2022 · 0 comments · Fixed by #5357
Closed

build: ids.config should only be installed when --enable-ids is set during configure #5356

glitsj16 opened this issue Sep 3, 2022 · 0 comments · Fixed by #5357

Comments

@glitsj16
Copy link
Collaborator

glitsj16 commented Sep 3, 2022

Currently I'm seeing /etc/firejail/ids.config without using --enable-ids during configure stage. IMO this might lead to some confusion and it would be cleaner if this file would only be installed according the feature's configuration.

Are there any objections/thoughts or things I might be overlooking in this regard?
@glitsj16 glitsj16 mentioned this issue Sep 3, 2022
Merged
glitsj16 added a commit to glitsj16/firejail that referenced this issue Sep 4, 2022
@glitsj16
build: only install ids.config when --enable-ids is set
36376a7 
This PR ensures ids.config only gets installed when --enable-ids is set during configure.
Fixes netblue30#5356.
glitsj16 added a commit that referenced this issue Sep 4, 2022
@glitsj16
build: only install ids.config when --enable-ids is set (#5357)
9aef909 
This PR ensures ids.config only gets installed when --enable-ids is set during configure.
Fixes #5356.
kmk3 added a commit that referenced this issue Nov 3, 2022
@kmk3
RELNOTES: add missing issue reference
65c80a6 
Relates to #5356.
@kmk3 kmk3 changed the title ids.config should only be installed when --enable-ids is set during configure build: ids.config should only be installed when --enable-ids is set during configure Nov 4, 2022
@kmk3 kmk3 moved this to Done (on RELNOTES) in Release 0.9.72 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Release 0.9.72
Status: Done (on RELNOTES)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: only install ids.config when --enable-ids is set glitsj16/firejail
1 participant
@glitsj16