-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: only install ids.config when --enable-ids is set #5357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to make it clearer (it sounds like ids.config currently isn't being
installed at all):
build: install ids.config when --enable-ids is set
->
build: install ids.config only when --enable-ids is set
Fix for #5356.
Please add such details to the commit message body, as it makes it easier to
track all commits related to a specific issue.
Other than that, LGTM.
@kmk3 Thanks for your review and suggestion. Updated accordingly. |
No problem.
Sorry, I meant in the commit message itself. Not sure about the web UI, but the commit message can be changed locally with: git fetch
git checkout ids-fix
git commit --amend
git push --force-with-lease |
This PR ensures ids.config only gets installed when --enable-ids is set during configure. Fixes netblue30#5356.
@kmk3 I hope I didn't break anything, thanks for your patience! |
This PR ensures ids.config only gets installed when --enable-ids is set during configure. Fixes #5356.