-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added youtube-viewer profile with Gtk frontends #3542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -41,6 +41,8 @@ whitelist /usr/share/misc | |||
whitelist /usr/share/Modules | |||
whitelist /usr/share/myspell | |||
whitelist /usr/share/p11-kit | |||
whitelist /usr/share/perl | |||
whitelist /usr/share/perl5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot profiles has whitelist /usr/share/perl5
. I'm not sure whether we should move it to wusc or keep it in profiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add it in the youtube-viewer profile or keep it open for discussion? Edit. Around 18-20 counting perl,per5,perl*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open for discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with this, whitelist /usr/share/perl*
should be removed from profiles. @Others opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say, add perl to wusc and remove the whitelist from profiles using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable-interpreters.inc blacklist
s /usr/share/perl*
, should be fine to allow it in wusc.
I'll correct the profiles once everything is resolved; if that's okay. Should be okay now, |
Initial,amend: wrong dir,delete gtk-*,added new files
Thanks for this contribution! |
Request: # 1139
Not sure if I should've made redirect profiles or separate.
Too many programs to add to private-bin, in my opinion, we should keep it commented.