Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added youtube-viewer profile with Gtk frontends #3542

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Added youtube-viewer profile with Gtk frontends #3542

merged 1 commit into from
Aug 11, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Jul 24, 2020

Request: # 1139

Not sure if I should've made redirect profiles or separate.

Too many programs to add to private-bin, in my opinion, we should keep it commented.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -41,6 +41,8 @@ whitelist /usr/share/misc
whitelist /usr/share/Modules
whitelist /usr/share/myspell
whitelist /usr/share/p11-kit
whitelist /usr/share/perl
whitelist /usr/share/perl5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot profiles has whitelist /usr/share/perl5. I'm not sure whether we should move it to wusc or keep it in profiles.

Copy link
Contributor Author

@bbhtt bbhtt Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to add it in the youtube-viewer profile or keep it open for discussion? Edit. Around 18-20 counting perl,per5,perl*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open for discussion

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with this, whitelist /usr/share/perl* should be removed from profiles. @Others opinions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, add perl to wusc and remove the whitelist from profiles using it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable-interpreters.inc blacklists /usr/share/perl*, should be fine to allow it in wusc.

etc/profile-m-z/youtube-viewer.profile Outdated Show resolved Hide resolved
etc/profile-m-z/youtube-viewer.profile Show resolved Hide resolved
etc/profile-m-z/youtube-viewer.profile Outdated Show resolved Hide resolved
@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 24, 2020

I'll correct the profiles once everything is resolved; if that's okay.

Should be okay now,

Initial,amend: wrong dir,delete gtk-*,added new files
@rusty-snake rusty-snake merged commit 35ec6b6 into netblue30:master Aug 11, 2020
@rusty-snake
Copy link
Collaborator

Thanks for this contribution!

@bbhtt bbhtt deleted the youtube-viewer branch August 12, 2020 07:30
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants