-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added youtube-viewer profile with Gtk frontends #3542
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Firejail profile for gtk-youtube-viewer | ||
| # Description: Gtk front-end to youtube-viewer | ||
| # This file is overwritten after every install/update | ||
| # Persistent local customizations | ||
| include gtk-youtube-viewer.local | ||
| # Persistent global definitions | ||
| # include globals.local | ||
|
|
||
| ignore quiet | ||
|
|
||
| noblacklist /tmp/.X11-unix | ||
| noblacklist ${RUNUSER}/wayland-* | ||
| noblacklist ${RUNUSER} | ||
|
|
||
| include whitelist-runuser-common.inc | ||
|
|
||
| # Redirect | ||
| include youtube-viewer.profile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Firejail profile for gtk2-youtube-viewer | ||
| # Description: Gtk front-end to youtube-viewer | ||
| # This file is overwritten after every install/update | ||
| # Persistent local customizations | ||
| include gtk2-youtube-viewer.local | ||
| # Persistent global definitions | ||
| # include globals.local | ||
|
|
||
| ignore quiet | ||
|
|
||
| noblacklist /tmp/.X11-unix | ||
| noblacklist ${RUNUSER}/wayland-* | ||
| noblacklist ${RUNUSER} | ||
|
|
||
| include whitelist-runuser-common.inc | ||
|
|
||
| # Redirect | ||
| include youtube-viewer.profile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Firejail profile for gtk3-youtube-viewer | ||
| # Description: Gtk front-end to youtube-viewer | ||
| # This file is overwritten after every install/update | ||
| # Persistent local customizations | ||
| include gtk3-youtube-viewer.local | ||
| # Persistent global definitions | ||
| # include globals.local | ||
|
|
||
| ignore quiet | ||
|
|
||
| noblacklist /tmp/.X11-unix | ||
| noblacklist ${RUNUSER}/wayland-* | ||
| noblacklist ${RUNUSER} | ||
|
|
||
| include whitelist-runuser-common.inc | ||
|
|
||
| # Redirect | ||
| include youtube-viewer.profile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Firejail profile for youtube-viewer | ||
| # Description: Trizen's CLI Youtube viewer with login support | ||
| # This file is overwritten after every install/update | ||
| quiet | ||
| # Persistent local customizations | ||
| include youtube-viewer.local | ||
| # Persistent global definitions | ||
| include globals.local | ||
|
|
||
| blacklist /tmp/.X11-unix | ||
| blacklist ${RUNUSER}/wayland-* | ||
| blacklist ${RUNUSER} | ||
|
|
||
| noblacklist ${HOME}/.config/youtube-viewer | ||
|
|
||
| include allow-perl.inc | ||
| include allow-python2.inc | ||
| include allow-python3.inc | ||
|
|
||
| include disable-common.inc | ||
| include disable-devel.inc | ||
| include disable-exec.inc | ||
| include disable-interpreters.inc | ||
| include disable-passwdmgr.inc | ||
| include disable-programs.inc | ||
| include disable-xdg.inc | ||
|
|
||
| mkdir ${HOME}/.config/youtube-viewer | ||
| whitelist ${HOME}/.config/youtube-viewer | ||
| include whitelist-common.inc | ||
| include whitelist-usr-share-common.inc | ||
| include whitelist-var-common.inc | ||
|
|
||
| apparmor | ||
| caps.drop all | ||
| netfilter | ||
| nodvd | ||
| nogroups | ||
| nonewprivs | ||
| noroot | ||
| notv | ||
| nou2f | ||
rusty-snake marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| novideo | ||
| protocol unix,inet,inet6 | ||
| seccomp | ||
| shell none | ||
| tracelog | ||
|
|
||
| disable-mnt | ||
| # private-bin ffmpeg,ffprobe,firefox,gtk-youtube-viewer,gtk2-youtube-viewer,gtk3-youtube-viewer,mpv,python*,smplayer,sh,which,vlc,youtube-dl,youtube-viewer | ||
| private-cache | ||
| private-dev | ||
| private-etc alsa,alternatives,asound.conf,ca-certificates,crypto-policies,fonts,gtk-2.0,gtk-3.0,host.conf,hostname,hosts,machine-id,mime.types,nsswitch.conf,passwd,pki,pulse,resolv.conf,ssl,X11,xdg | ||
| private-tmp | ||
|
|
||
| dbus-user none | ||
| dbus-system none | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot profiles has
whitelist /usr/share/perl5. I'm not sure whether we should move it to wusc or keep it in profiles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add it in the youtube-viewer profile or keep it open for discussion? Edit. Around 18-20 counting perl,per5,perl*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open for discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with this,
whitelist /usr/share/perl*should be removed from profiles. @Others opinions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say, add perl to wusc and remove the whitelist from profiles using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable-interpreters.inc
blacklists/usr/share/perl*, should be fine to allow it in wusc.