Rework issue templates #4515
Rework issue templates #4515
Conversation
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
|
|
||
| ### Checklist | ||
|
|
||
| - [ ] The profile (and redirect profile if exists) hasn't already been fixed [upstream](https://github.com/netblue30/firejail/tree/master/etc). | ||
| - [ ] The issues is caused by firejail (i.e running the program by path (e.g. `/usr/bin/vlc`) "fixes" it). |
There was a problem hiding this comment.
Or maybe move both here:
| - [ ] The issues is caused by firejail (i.e running the program by path (e.g. `/usr/bin/vlc`) "fixes" it). | |
| - [ ] The issue is caused by the firejail profile (i.e. it works using `firejail --noprofile /path/to/program`). | |
| - [ ] The issue is caused by firejail (i.e it works using `/path/to/program`). |
There was a problem hiding this comment.
Thanks for adding me a reviewer and sorry for the delay.
I have some thoughts on bug_report.md, but it's kind of hard to review using
the default tools, considering the amount of changes done at once. Can I just
commit my ideas to the branch and then you keep what you agree with and delete
(and maybe comment on) the rest?
|
|
||
| ### Additional context | ||
|
|
||
| _Add any other context or screenshots about the feature request here._ |
There was a problem hiding this comment.
I like the idea of having a feature request template.
But what about the "Ideas" category?
When would a feature request be posted using the template vs in a new
discussion?
There was a problem hiding this comment.
Good points. Spontaneous I would say use "Ideas" if you have an idea and if we come to something more concrete (i.e. how a new option should integrate into profiles, ...) a detailed feature request is written.
There was a problem hiding this comment.
Good points. Spontaneous I would say use "Ideas" if you have an idea and if
we come to something more concrete (i.e. how a new option should integrate
into profiles, ...) a detailed feature request is written.
I thought the same. My worry was mostly that even without a template people
sometimes already open issues for less detailed feature requests instead of
using discussions. But I guess we can convert to a discussion in those cases,
so nevermind.
There was a problem hiding this comment.
Maybe we should add a not to feature_request.md (in a later PR) or to CONTRIBUTING.md.
Where we are already at CONTRIBUTING.md, this needs to be updated too. Especially for discussions.
+1 |
|
I have pushed some commits; feel free to squash/fixup any. I had some larger suggestions, but honestly they're not worth keeping this open There are also some more ideas that I'll just put in a new PR. |
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
rusty-snake
force-pushed
the
rework-issue-template
branch
from
dddfced
to
b3212ed
Compare
|
@rusty-snake By the way, feel free to squash/fixup commits like this that I
That is, commits that only fix typos/whitespace/indentation of other commits in They're just mechanical changes to (at the time of making) unmerged commits, so To make things simpler, I think I'll just write "(fixup)" in the commit message |
I had overlooked
Sounds better as it allows a simple |
|
@rusty-snake commented on Sep 19:
Alright, I'll do that one then. OT: I wish everyone knew how to rebase, so that I could do this on every PR |
Changes: * Sync bug_report.md with build_issue.md (reword items and add Linux kernel item) * Add a colon to the end of every item (to clarify where to add the information) * Add the Environment section to feature_request.md The last item is intended as a basic sanity check, as users using an outdated version of firejail may request something that was already implemented (for example, see netblue30#6461). Relates to netblue30#4515 netblue30#6423.
Changes: * Sync bug_report.md with build_issue.md (reword items and add Linux kernel item) * Add a colon to the end of every item (to clarify where to add the information) * Add the Environment section to feature_request.md The last item is intended as a basic sanity check, as users using an outdated version of firejail may request something that was already implemented (for example, see netblue30#6461). Relates to netblue30#4515 netblue30#6423.
Changes: * Sync bug_report.md with build_issue.md (reword items and add Linux kernel item) * Add a colon to the end of every item (to clarify where to add the information) * Add the Environment section to feature_request.md The last item is intended as a basic sanity check, as users using an outdated version of firejail may request something that was already implemented (for example, see #6461). Relates to #4515 #6423.
No description provided.