-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue template improvements2 #4561
Conversation
This overrides all `LC_*` variables (and LANG) rather than just LANG. From Section 8.2, Internationalization Variables of POSIX.1-2017[1]: > LANG > This variable shall determine the locale category for native > language, local customs, and coded character set in the absence of > the LC_ALL and other LC_* (LC_COLLATE, LC_CTYPE, LC_MESSAGES, > LC_MONETARY, LC_NUMERIC, LC_TIME) environment variables. This can > be used by applications to determine the language to use for error > messages and instructions, collating sequences, date formats, and > so on. > > LC_ALL > This variable shall determine the values for all locale > categories. The value of the LC_ALL environment variable has > precedence over any of the other environment variables starting > with LC_ (LC_COLLATE, LC_CTYPE, LC_MESSAGES, LC_MONETARY, > LC_NUMERIC, LC_TIME) and the LANG environment variable. [1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but see my comment below.
@@ -44,6 +44,7 @@ _Any other detail that may help to understand/debug the problem_ | |||
|
|||
### Checklist | |||
|
|||
- [x] This is a checked item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for this.
I am not sure if this is the prettiest solution (having an own ugly example checkitem). Maybe something like
<!--
- [x] This is a checked item.
-->
### Checklist (check them like this `- [x]`)
Maybe it would make sense to link to https://guides.github.com/features/mastering-markdown/ too. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this.
I am not sure if this is the prettiest solution (having an own ugly example
checkitem).
Certainly not a pretty solution, though it's the most dummy-proof one that I
could think of. And considering the formatting of some issues, dummy-proofing
seems like a helpful quality...
Maybe something like
<!-- - [x] This is a checked item. -->
I had thought about doing this, but it seemed a bit less obvious and it takes
more space. If it works, it's good enough though. Added it.
Maybe it would make sense to link to
https://guides.github.com/features/mastering-markdown/ too. WDYT?
Done.
It is not uncommon for people to use other characters to try to mark an item as checked (which usually screws up the html output), so be sure to include an example with "[x]".
As suggested by @rusty-snake.
b7f9a32
to
2072736
Compare
Use
LC_ALL
and add a checked item example.Relates to #4479 and #4515.