build: standardize install commands #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove the extraneous semicolon at the end of the command string. See also commit dae3933 ("rework make realinstall and uninstall (netblue30#3435)", 2020-06-04).
The command below already installs it. Added on commit 9267904 ("add basic Firejail support to AppArmor base abstraction (netblue30#3226)", 2021-10-21) / PR netblue30#4628.
Changes: * Remove / after `$(DESTDIR)` * Remove useless -c * Use 0755 instead of 755 * Use -d after -m See also commit dae3933 ("rework make realinstall and uninstall (netblue30#3435)", 2020-06-04).
Just try to install them, as is done in the other `$(INSTALL) -d` commands.
For increased consistency and readability.
For increased consistency and readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For increased consistency and readability.
See also commit dae3933 ("rework make realinstall and uninstall
(#3435)", 2020-06-04).
Relates to #3435 #4628.
Cc: @rusty-snake @smitsohu