Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: standardize install commands #6366

Merged
merged 6 commits into from
Jun 10, 2024
Merged

build: standardize install commands #6366

merged 6 commits into from
Jun 10, 2024

Commits on Jun 2, 2024

  1. build: line-break sh install commands 

    And remove the extraneous semicolon at the end of the command string.

See also commit dae3933 ("rework make realinstall and uninstall
(netblue30#3435)", 2020-06-04).
    @kmk3
    kmk3 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    c633ba3 View commit details
    Browse the repository at this point in the history

  2. build: remove redundant parent dir install 

    The command below already installs it.

Added on commit 9267904 ("add basic Firejail support to AppArmor base
abstraction (netblue30#3226)", 2021-10-21) / PR netblue30#4628.
    @kmk3
    kmk3 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    6b35ed7 View commit details
    Browse the repository at this point in the history

  3. build: fix some inconsistencies in install commands 

    Changes:

* Remove / after `$(DESTDIR)`
* Remove useless -c
* Use 0755 instead of 755
* Use -d after -m

See also commit dae3933 ("rework make realinstall and uninstall
(netblue30#3435)", 2020-06-04).
    @kmk3
    kmk3 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    afdb371 View commit details
    Browse the repository at this point in the history

  4. build: stop checking for dir existence on install 

    Just try to install them, as is done in the other `$(INSTALL) -d`
commands.
    @kmk3
    kmk3 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    5430535 View commit details
    Browse the repository at this point in the history

  5. build: use -t in applicable install commands 

    For increased consistency and readability.
    @kmk3
    kmk3 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    e30c57e View commit details
    Browse the repository at this point in the history

  6. build: sort/split some install commands 

    For increased consistency and readability.
    @kmk3
    kmk3 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    68d06a1 View commit details
    Browse the repository at this point in the history