#249 [Housekeeping]: Use NetBoxObjectType for GraphQL #250
+70
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor GraphQL module imports for clarity and consistency. Updated formatting to adhere to code standards without modifying functionality or behavior. Fixes: netbox-community#249
Refactors AccessListType and related classes to use NetBoxObjectType. This improves consistency by aligning with the updated base type in the codebase. No functional changes introduced. Fixes: netbox-community#249
Eliminates unnecessary Meta classes and associated GraphQL fields for ACL models. Fixes: netbox-community#249
Reordered GraphQL classes to follow the structure of their corresponding NetBox models, improving consistency and maintainability. Fixes: netbox-community#249
Updates the `source_ports` and `destination_ports` fields to support null values. This ensures compatibility with cases where no ports are specified. Fixes: netbox-community#249
Updates `source_prefix` and `destination_prefix` fields to be nullable. This ensures compatibility with cases where prefixes may not be provided. Fixes: netbox-community#249
This was referenced Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Fixes: #249 – [Housekeeping] Use
NetBoxObjectTypefor GraphQLNew Behavior
OrganizationalObjectTypewithNetBoxObjectTypein GraphQL.Metaclass from GraphQL types.Contrast to Current Behavior
source_portsanddestination_portsnow supportnullvalues, ensuring compatibility when no ports are specified.source_prefixanddestination_prefixfields are now nullable, preventing errors when prefixes are not provided.Discussion: Benefits and Drawbacks
NetBoxModel, which includes several feature mixins. These features were missing when usingOrganizationalObjectTypeas the parent class in GraphQL. Switching toNetBoxObjectTypeensures that all NetBox model features are properly available in GraphQL.Changes to the Documentation
None required (behavior remains consistent with expected NetBox GraphQL functionality).
Proposed Release Note Entry
None required (internal improvement).
Double Check
or in a linked issue.
devbranch.