Optimize ACL rule table columns #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, I’ve submitted netbox-community/netbox#20115 to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
None
New Behavior
Several changes have been made to the ACL rules tables:
Contrast to Current Behavior
Values are not clickable right now.
Discussion: Benefits and Drawbacks
I’ve decided to reuse the
ArrayColumnfrom NetBox’s core, even though the documentation states that it’s not part of the official API. I don’t anticipate any significant changes to this column in the near future, but if it’s a major issue, I can either implement a custom version or copy its code.Changes to the Documentation
None
Proposed Release Note Entry
Improve the user experience of Access List rule tables.
Double Check
devbranch.