Fixes #12847 - Include Missing Add buttons to Views #12864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Jun 13, 2023
netbox/dcim/views.py
Outdated
| @@ -2193,7 +2193,7 @@ class ConsolePortListView(generic.ObjectListView): | |||
| filterset = filtersets.ConsolePortFilterSet | |||
| filterset_form = forms.ConsolePortFilterForm | |||
| table = tables.ConsolePortTable | |||
| actions = ('import', 'export', 'bulk_edit', 'bulk_delete') | |||
| actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete') | |||
There was a problem hiding this comment.
ActionsMixin sets this list by default, so we can instead just remove the definition for actions from each view.
class ActionsMixin:
actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete')
Suggested change
| actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete') |
Signed-off-by: Sudheesh Singanamalla <sudheesh@cs.washington.edu>
sudheesh001
force-pushed
the
fix/12847-include-adds
branch
from
a1b7120
to
c5f71c0
Compare
|
Thanks for the review @jeremystretch I just updated the PR based on your feedback. Please let me know if this would be a better patch. |
|
That'll work, thanks! |
jeremystretch
approved these changes
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12847
Addbutton in Views forDevice ComponentsAddbutton in Views forVirtualization > Interfaces